Page MenuHomeSoftware Heritage
Feed Advanced Search

Apr 23 2020

anlambert added a comment to D3046: browse: Disambiguate URLs related to origin / snapshot context.

I am not sure we want to keep that dateutil.parser.parse. Its function input
is a plain string (quite large) and its output is sometimes unexpected [1]

We already discussed in other modules that we should converge on using iso8601
dates (well use that module at least). So might be, it'd be best to use more
conventional timestamp formats, iso8601 sounds like one sensible choice for at
least one format.

I imagine we have that behavior already so that might be another task entirely.
I just mention it here since we are reworking endpoints.

Apr 23 2020, 12:07 PM
anlambert added a comment to D3046: browse: Disambiguate URLs related to origin / snapshot context.

Wouldn't this be a good time to also move the URL to a query parameter? (Because of the double-slash issue that can happen on clients)

Apr 23 2020, 11:59 AM

Apr 22 2020

anlambert retitled D3046: browse: Disambiguate URLs related to origin / snapshot context from browse: Disambiguate URLs related to origin / snapshot context browsing to browse: Disambiguate URLs related to origin / snapshot context.
Apr 22 2020, 6:19 PM
anlambert updated the diff for D3046: browse: Disambiguate URLs related to origin / snapshot context.

Update: Doc fix

Apr 22 2020, 6:17 PM
anlambert added a revision to T2115: Directories named 'directory' cannot be browsed in snapshot context views: D3046: browse: Disambiguate URLs related to origin / snapshot context.
Apr 22 2020, 6:07 PM · Web app
anlambert added a revision to T2135: Disambiguate browse URL regexps: D3046: browse: Disambiguate URLs related to origin / snapshot context.
Apr 22 2020, 6:07 PM · Web app
anlambert created D3046: browse: Disambiguate URLs related to origin / snapshot context.
Apr 22 2020, 6:07 PM
anlambert added a subtask for T2342: Add resolving of new SWHIDs contextual information: T2135: Disambiguate browse URL regexps.
Apr 22 2020, 4:51 PM · Web app
anlambert added a parent task for T2135: Disambiguate browse URL regexps: T2342: Add resolving of new SWHIDs contextual information.
Apr 22 2020, 4:51 PM · Web app
anlambert committed rDWAPPS09e18940394e: templates/directory-display: Display message for missing directory/revision (authored by anlambert).
templates/directory-display: Display message for missing directory/revision
Apr 22 2020, 12:54 PM
anlambert committed rDWAPPS6708b108fbee: package.json: Upgrade dependencies (authored by anlambert).
package.json: Upgrade dependencies
Apr 22 2020, 12:54 PM
anlambert closed D3042: templates/directory-display: Display message when directory/revision is missing.
Apr 22 2020, 12:54 PM
anlambert updated the diff for D3042: templates/directory-display: Display message when directory/revision is missing.

Update: Fix test syntax in django template (no line break allowed, sigh ...)

Apr 22 2020, 12:38 PM
anlambert updated the diff for D3042: templates/directory-display: Display message when directory/revision is missing.

Update: Remove redundant error message in template and prevent django.template.base.VariableDoesNotExist exception

Apr 22 2020, 12:20 PM
anlambert added a comment to D3042: templates/directory-display: Display message when directory/revision is missing.

Ack, I will land the diff and push a new swh-web tag.

Apr 22 2020, 12:10 PM
anlambert added a comment to D3042: templates/directory-display: Display message when directory/revision is missing.

I should be able to work something out for that one.

Apr 22 2020, 12:05 PM
anlambert added a comment to D3042: templates/directory-display: Display message when directory/revision is missing.

we are missing the test case about revision ok

Apr 22 2020, 11:39 AM

Apr 21 2020

anlambert added a comment to D3042: templates/directory-display: Display message when directory/revision is missing.

I added an extra check for the revision if the directory is None in order to improve error message.

Apr 21 2020, 7:31 PM
anlambert retitled D3042: templates/directory-display: Display message when directory/revision is missing from templates/directory-display: Display message when directory is missing to templates/directory-display: Display message when directory/revision is missing.
Apr 21 2020, 7:30 PM
anlambert updated the diff for D3042: templates/directory-display: Display message when directory/revision is missing.

Update: Improve error message for missing revision

Apr 21 2020, 7:29 PM
anlambert added a comment to T2353: Improve snapshot browsing when error occurs.

D3042 handles the branch with non resolvable revision case.

Apr 21 2020, 7:03 PM · Web app
anlambert added a revision to T2353: Improve snapshot browsing when error occurs: D3042: templates/directory-display: Display message when directory/revision is missing.
Apr 21 2020, 7:01 PM · Web app
anlambert created D3042: templates/directory-display: Display message when directory/revision is missing.
Apr 21 2020, 7:01 PM
anlambert committed rDWAPPS40ac1374bc4a: browse/snapshot_context: Refactor, add type annotations and tests (authored by anlambert).
browse/snapshot_context: Refactor, add type annotations and tests
Apr 21 2020, 6:58 PM
anlambert closed T2360: Reorganize and refactor snapshot browsing related code as Resolved by committing rDWAPPS40ac1374bc4a: browse/snapshot_context: Refactor, add type annotations and tests.
Apr 21 2020, 6:58 PM · Web app
anlambert closed T2360: Reorganize and refactor snapshot browsing related code, a subtask of T2342: Add resolving of new SWHIDs contextual information, as Resolved.
Apr 21 2020, 6:58 PM · Web app
anlambert closed D3041: browse/snapshot_context: Refactor, add type annotations and tests.
Apr 21 2020, 6:58 PM
anlambert added a comment to T2353: Improve snapshot browsing when error occurs.

I have updated D3041 to restore previous behavior and look what I got now:

seems better ;-)

Apr 21 2020, 6:15 PM · Web app
anlambert changed the visibility for F3834618: image.png.
Apr 21 2020, 6:13 PM
anlambert updated the diff for D3041: browse/snapshot_context: Refactor, add type annotations and tests.

Update: Do not filtered out branches with a non resolvable revision (restore previous behavior)

Apr 21 2020, 6:10 PM
anlambert added a comment to T2353: Improve snapshot browsing when error occurs.

Apparently, the changes I introduced in D3041 makes the above issue disappear ... I need to dig further on this.

Apr 21 2020, 5:58 PM · Web app
anlambert added a comment to T2353: Improve snapshot browsing when error occurs.

Apparently, the changes I introduced in D3041 makes the above issue disappear ... I need to dig further on this.

Apr 21 2020, 5:43 PM · Web app
anlambert added a comment to D3041: browse/snapshot_context: Refactor, add type annotations and tests.

I think it's fine :D

It's "slightly" big ;)

Apr 21 2020, 5:34 PM
anlambert added a comment to T2353: Improve snapshot browsing when error occurs.

I see where the issue is, diff incoming ;-)

Apr 21 2020, 4:44 PM · Web app
anlambert updated the summary of D3041: browse/snapshot_context: Refactor, add type annotations and tests.
Apr 21 2020, 4:36 PM
anlambert updated the summary of D3041: browse/snapshot_context: Refactor, add type annotations and tests.
Apr 21 2020, 4:36 PM
anlambert created D3041: browse/snapshot_context: Refactor, add type annotations and tests.
Apr 21 2020, 4:35 PM
anlambert added a revision to T2360: Reorganize and refactor snapshot browsing related code: D3041: browse/snapshot_context: Refactor, add type annotations and tests.
Apr 21 2020, 4:35 PM · Web app
anlambert committed rDWAPPS88847f09e874: get_origin_visit: Return first visit with non null snapshot by default (authored by anlambert).
get_origin_visit: Return first visit with non null snapshot by default
Apr 21 2020, 2:00 PM
anlambert closed D3038: Return first visit with non null snapshot by default.
Apr 21 2020, 2:00 PM
anlambert added a revision to T2353: Improve snapshot browsing when error occurs: D3038: Return first visit with non null snapshot by default.
Apr 21 2020, 12:49 PM · Web app
anlambert added a task to D3038: Return first visit with non null snapshot by default: T2353: Improve snapshot browsing when error occurs.
Apr 21 2020, 12:49 PM
anlambert created D3038: Return first visit with non null snapshot by default.
Apr 21 2020, 12:33 PM
anlambert created P650 swh-web: Fix latest valid snapshot browsing.
Apr 21 2020, 11:44 AM

Apr 20 2020

anlambert updated the task description for T2360: Reorganize and refactor snapshot browsing related code.
Apr 20 2020, 6:44 PM · Web app
anlambert committed rDWAPPS6cb30056a844: common.utils.context_processor: Check user attr existence in request (authored by anlambert).
common.utils.context_processor: Check user attr existence in request
Apr 20 2020, 5:31 PM
anlambert closed D3035: common.utils.context_processor: Check user attr existence in request.
Apr 20 2020, 5:31 PM
anlambert updated the diff for D3035: common.utils.context_processor: Check user attr existence in request.

Rebase

Apr 20 2020, 5:30 PM
anlambert updated the diff for D3035: common.utils.context_processor: Check user attr existence in request.

Update: Use simpler hardcoded URL in test

Apr 20 2020, 3:54 PM
anlambert updated the diff for D3035: common.utils.context_processor: Check user attr existence in request.

Update: Add test

Apr 20 2020, 3:52 PM
anlambert created D3035: common.utils.context_processor: Check user attr existence in request.
Apr 20 2020, 2:12 PM

Apr 17 2020

anlambert committed rDWAPPS1427f48610ab: package.json: Upgrade depencies (authored by anlambert).
package.json: Upgrade depencies
Apr 17 2020, 5:04 PM
anlambert committed rDWAPPSb76fa13a4fa1: cypress/utils: Fix eslint warning (authored by anlambert).
cypress/utils: Fix eslint warning
Apr 17 2020, 5:04 PM
anlambert committed rDWAPPS8db7f4203a66: pre-commit-config: Globally exclude tests resources file tree (authored by anlambert).
pre-commit-config: Globally exclude tests resources file tree
Apr 17 2020, 5:04 PM
anlambert closed D3027: Fix "make check" issues and upgrade npm dependencies.
Apr 17 2020, 5:04 PM
anlambert updated the diff for D3027: Fix "make check" issues and upgrade npm dependencies.

Rebase

Apr 17 2020, 5:04 PM
anlambert created D3027: Fix "make check" issues and upgrade npm dependencies.
Apr 17 2020, 4:08 PM
anlambert closed T1241: Persistent identifiers (PIDs): add a way to describe Merkle DAG paths, a subtask of T2330: Simplify Permalinks box, as Resolved.
Apr 17 2020, 11:26 AM · UX, 2019 UX audit, Web app
anlambert closed T1241: Persistent identifiers (PIDs): add a way to describe Merkle DAG paths as Resolved.

It seems Phabricator reopened the task automatically with my last comment, that was not intended.

Apr 17 2020, 11:26 AM · UX, Web app, General
anlambert closed T1241: Persistent identifiers (PIDs): add a way to describe Merkle DAG paths, a subtask of T2366: Review Persistent identifiers (PIDs) with context in deposit, as Resolved.
Apr 17 2020, 11:26 AM · SWORD deposit
anlambert reopened T1241: Persistent identifiers (PIDs): add a way to describe Merkle DAG paths as "Work in Progress".

@moranegg , for the branch case the anchor will be the revision it points to. For your example, it will be

Apr 17 2020, 9:59 AM · UX, Web app, General
anlambert reopened T1241: Persistent identifiers (PIDs): add a way to describe Merkle DAG paths, a subtask of T2330: Simplify Permalinks box, as Work in Progress.
Apr 17 2020, 9:59 AM · UX, 2019 UX audit, Web app
anlambert reopened T1241: Persistent identifiers (PIDs): add a way to describe Merkle DAG paths, a subtask of T2366: Review Persistent identifiers (PIDs) with context in deposit, as Work in Progress.
Apr 17 2020, 9:59 AM · SWORD deposit

Apr 15 2020

anlambert committed rDWAPPS533628aa89a4: pytest.ini: Update filterwarnings after new hypothesis release (authored by anlambert).
pytest.ini: Update filterwarnings after new hypothesis release
Apr 15 2020, 6:45 PM
anlambert committed rDWAPPS7d137314d28f: tests: Refactor test checking origin browsing errors (authored by anlambert).
tests: Refactor test checking origin browsing errors
Apr 15 2020, 6:45 PM
anlambert closed D3022: tests: Refactor test checking origin browsing errors.
Apr 15 2020, 6:45 PM
anlambert committed rDWAPPS9ad1d27bd4e0: browse: Merge snapshot context related functions in dedicated module (authored by anlambert).
browse: Merge snapshot context related functions in dedicated module
Apr 15 2020, 6:45 PM
anlambert closed D3021: browse: Merge snapshot context related functions in dedicated module.
Apr 15 2020, 6:45 PM
anlambert updated the diff for D3022: tests: Refactor test checking origin browsing errors.
  • add assert mock*.*.called checks
Apr 15 2020, 6:13 PM
anlambert added inline comments to D3021: browse: Merge snapshot context related functions in dedicated module.
Apr 15 2020, 5:16 PM
anlambert created D3022: tests: Refactor test checking origin browsing errors.
Apr 15 2020, 5:15 PM
anlambert added inline comments to D3021: browse: Merge snapshot context related functions in dedicated module.
Apr 15 2020, 3:44 PM
anlambert created D3021: browse: Merge snapshot context related functions in dedicated module.
Apr 15 2020, 3:34 PM
anlambert accepted D3019: git.loader: fix failing origin visit update step due to uninitialized internal state variables.

I got the exact same situation when I updated the mercurial loader to swh-model objects.

Apr 15 2020, 11:42 AM · Git loader

Apr 14 2020

anlambert triaged T2360: Reorganize and refactor snapshot browsing related code as Normal priority.
Apr 14 2020, 3:37 PM · Web app
anlambert updated the task description for T2359: Add snapshot id query parameter in numerous browse views.
Apr 14 2020, 1:32 PM · Web app
anlambert added a subtask for T2342: Add resolving of new SWHIDs contextual information: T2359: Add snapshot id query parameter in numerous browse views.
Apr 14 2020, 1:32 PM · Web app
anlambert added a parent task for T2359: Add snapshot id query parameter in numerous browse views: T2342: Add resolving of new SWHIDs contextual information.
Apr 14 2020, 1:32 PM · Web app
anlambert triaged T2359: Add snapshot id query parameter in numerous browse views as Normal priority.
Apr 14 2020, 1:31 PM · Web app

Apr 10 2020

anlambert committed rDWAPPS6cd93e8e8ea4: package.json: Upgrade dependencies (authored by anlambert).
package.json: Upgrade dependencies
Apr 10 2020, 7:34 PM
anlambert closed T1680: Properly bundle MathJax once version 3.0 is released as Resolved by committing rDWAPPS2a3c117fbd9b: assets: Upgrade MathJax to 3.x and bundle it with webpack.
Apr 10 2020, 7:34 PM · Web app
anlambert committed rDWAPPS2a3c117fbd9b: assets: Upgrade MathJax to 3.x and bundle it with webpack (authored by anlambert).
assets: Upgrade MathJax to 3.x and bundle it with webpack
Apr 10 2020, 7:34 PM
anlambert closed D3009: assets: Upgrade MathJax to 3.x and bundle it with webpack.
Apr 10 2020, 7:34 PM
anlambert updated the diff for D3009: assets: Upgrade MathJax to 3.x and bundle it with webpack.

Update: Upgrade mathjax to 3.0.5 (version was released after I pushed the diff)

Apr 10 2020, 6:12 PM
anlambert added a comment to D3009: assets: Upgrade MathJax to 3.x and bundle it with webpack.

Yes sure, but I meant to self-host it instead of using a CDN

Apr 10 2020, 5:19 PM
anlambert added a comment to D3009: assets: Upgrade MathJax to 3.x and bundle it with webpack.

Is it really worth it?

Apr 10 2020, 4:53 PM
anlambert created D3009: assets: Upgrade MathJax to 3.x and bundle it with webpack.
Apr 10 2020, 3:34 PM
anlambert committed rDENV682f23ced2e7: docker/conftest: Speedup pytest based tests execution (authored by anlambert).
docker/conftest: Speedup pytest based tests execution
Apr 10 2020, 10:44 AM
anlambert closed D2999: docker/conftest: Speedup pytest based tests execution.
Apr 10 2020, 10:44 AM

Apr 9 2020

anlambert committed rDLDBASE63d9baa39792: Fix a couple of storage args deprecation warnings (authored by anlambert).
Fix a couple of storage args deprecation warnings
Apr 9 2020, 8:22 PM
anlambert committed rDLDBASE20f161337444: cli: Sort loaders list and fix some tests (authored by anlambert).
cli: Sort loaders list and fix some tests
Apr 9 2020, 8:22 PM
anlambert closed D2996: Fix a couple of storage args deprecation warnings.
Apr 9 2020, 8:22 PM
anlambert closed D2995: cli: Sort loaders list and fix some tests.
Apr 9 2020, 8:22 PM
anlambert added a comment to D2987: Add a wrapper to manage a sorted list..

I am not sure if explicitly setting the key type when instantiating a SortedList instance is a real necessity.
How about simplifying a little bit in order to simply write sha1s = SortedList[bytes] ?

Apr 9 2020, 7:18 PM
anlambert accepted D3000: Remove unittest from test_serializers.
Apr 9 2020, 6:25 PM
anlambert created D2999: docker/conftest: Speedup pytest based tests execution.
Apr 9 2020, 6:18 PM
anlambert committed rDENV9c7d2f232db3: conf/scheduler: Fix broker URL by encoding default vhost (/) to %2f (authored by anlambert).
conf/scheduler: Fix broker URL by encoding default vhost (/) to %2f
Apr 9 2020, 5:31 PM
anlambert closed D2998: conf/scheduler: Fix broker URL by encoding default vhost (/) to %2f.
Apr 9 2020, 5:31 PM
anlambert created D2998: conf/scheduler: Fix broker URL by encoding default vhost (/) to %2f.
Apr 9 2020, 5:26 PM
anlambert created D2996: Fix a couple of storage args deprecation warnings.
Apr 9 2020, 4:00 PM