Page MenuHomeSoftware Heritage

Return first visit with non null snapshot by default
ClosedPublic

Authored by anlambert on Apr 21 2020, 12:33 PM.

Details

Summary

When no timestamp or visit id is provided to the get_origin_visit function,
return the first visit with a non null snapshot instead of the first full
visit. Indeed, a partial visit can have a valid snapshot and should be not
filtered out.

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D3038 (id=10794)

Rebasing onto 6cb30056a8...

Current branch diff-target is up to date.
Changes applied before test
commit 88847f09e87421fd15d576989806956bf9734eeb
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue Apr 21 12:25:29 2020 +0200

    get_origin_visit: Return first visit with non null snapshot by default
    
    When no timestamp or visit id is provided to the get_origin_visit function,
    return the first visit with a non null snapshot instead of the first full
    visit. Indeed, a partial visit can have a valid snapshot and should be not
    filtered out.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/70/ for more details.

This revision is now accepted and ready to land.Apr 21 2020, 1:58 PM