Page MenuHomeSoftware Heritage
Differential D3021

browse: Merge snapshot context related functions in dedicated module
ClosedPublic
Actions

Authored by anlambert on Apr 15 2020, 3:34 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDWAPPS9ad1d27bd4e0: browse: Merge snapshot context related functions in dedicated module
Summary

First part of T2360 and not really interesting to review.

The diff simply moves existing code to a new module swh.web.browse.snapshot_context.

Some import reorganization and URL regexps polishing in swh.web.browse.views.origin have also been performed.

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Apr 15 2020, 3:34 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptApr 15 2020, 3:34 PM
ardumont accepted this revision.Apr 15 2020, 3:41 PM
ardumont added a subscriber: ardumont.
ardumont added inline comments.
swh/web/tests/browse/views/test_origin.py
445

That test is a pita ;)

This revision is now accepted and ready to land.Apr 15 2020, 3:41 PM
swh-public-ci added a comment.Apr 15 2020, 3:42 PM

Build is green

Patch application report for D3021 (id=10734)

Rebasing onto 6cd93e8e8e...

Current branch diff-target is up to date.
Changes applied before test
commit 9ad1d27bd4e092161cfd1badf6814b560feeefc9
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue Apr 14 17:15:39 2020 +0200

    browse: Merge snapshot context related functions in dedicated module
    
    Related to T2360

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/60/ for more details.

Harbormaster completed remote builds in B11855: Diff 10734.Apr 15 2020, 3:42 PM
anlambert added inline comments.Apr 15 2020, 3:44 PM
swh/web/tests/browse/views/test_origin.py
445

Yep, it is awful ! I must refactor that s**t and create one test case for each error.

ardumont added inline comments.Apr 15 2020, 3:52 PM
swh/web/tests/browse/views/test_origin.py
445

yes, it grew out of proportion.

have *fun* ;)

anlambert added a child revision: D3022: tests: Refactor test checking origin browsing errors.Apr 15 2020, 5:15 PM
anlambert added inline comments.Apr 15 2020, 5:16 PM
swh/web/tests/browse/views/test_origin.py
445

D3022 \o/

Closed by commit rDWAPPS9ad1d27bd4e0: browse: Merge snapshot context related functions in dedicated module (authored by anlambert). · Explain WhyApr 15 2020, 6:45 PM
This revision was automatically updated to reflect the committed changes.
anlambert added a commit: rDWAPPS9ad1d27bd4e0: browse: Merge snapshot context related functions in dedicated module.

Revision Contents
Changeset List

PathSize
swh/
web/
browse/
views/
utils/
339 lines
328 lines
views/
10 lines
12 lines
18 lines
8 lines
18 lines
2 lines
utils/
tests/
browse/
74 lines
88 lines
views/
40 lines

Diff 10737

View Options

swh/web/browse/snapshot_context.py

Loading...
View Options

swh/web/browse/utils.py

Loading...
View Options

swh/web/browse/views/content.py

Loading...
View Options

swh/web/browse/views/directory.py

Loading...
View Options

swh/web/browse/views/origin.py

Loading...
View Options

swh/web/browse/views/release.py

Loading...
View Options

swh/web/browse/views/revision.py

Loading...
View Options

swh/web/browse/views/snapshot.py

Loading...
View Options

swh/web/browse/views/utils/__init__.py

Loading...
View Options

swh/web/browse/views/utils/snapshot_context.py

Loading...
View Options

swh/web/tests/browse/test_snapshot_context.py

Loading...
View Options

swh/web/tests/browse/test_utils.py

Loading...
View Options

swh/web/tests/browse/views/test_origin.py

Loading...
About · Developer information · Legal