Differential D2995

cli: Sort loaders list and fix some tests
ClosedPublic
Actions

Authored by anlambert on Apr 9 2020, 3:54 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLDBASE20f161337444: cli: Sort loaders list and fix some tests

Summary

New tests are failing since the number of available loaders increased.
Associated loaders list gets now wrapped in cli help output so we need
to take this into account in tests implementation.

See commands output below:

13:04 $ swh loader list --help
Usage: swh loader list [OPTIONS] [[all|archive|cran|debian|deposit|git|mercuri
                       al|nixguix|npm|pypi|svn]]

  List supported loaders and optionally their arguments

Options:
  -h, --help  Show this message and exit.

15:53 $ swh loader run --help
Usage: swh loader run [OPTIONS] [archive|cran|debian|deposit|git|mercurial|nix
                      guix|npm|pypi|svn] URL [OPTIONS]...

  Ingest with loader <type> the origin located at <url>

Options:
  -h, --help  Show this message and exit.

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Apr 9 2020, 3:54 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 9 2020, 3:54 PM

Build is green

Patch application report for D2995 (id=10639)

Rebasing onto 89828fa6c3...

Current branch diff-target is up to date.

Changes applied before test

commit 20f161337444933775e5d22841f0ebc89a81ed6b
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Apr 9 15:48:10 2020 +0200

    cli: Sort loaders list and fix some tests
    
    New tests are failing since the number of available loaders increased.
    Associated loaders list gets now wrapped in cli help output so we need
    to take this into account in tests implementation.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/16/ for more details.

Harbormaster completed remote builds in B11759: Diff 10639.Apr 9 2020, 3:56 PM

anlambert added a child revision: D2996: Fix a couple of storage args deprecation warnings.Apr 9 2020, 4:00 PM

Right!

Thanks.

ardumont accepted this revision.Apr 9 2020, 4:19 PM

This revision is now accepted and ready to land.Apr 9 2020, 4:19 PM

Closed by commit rDLDBASE20f161337444: cli: Sort loaders list and fix some tests (authored by anlambert). · Explain WhyApr 9 2020, 8:22 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDLDBASE20f161337444: cli: Sort loaders list and fix some tests.