Page MenuHomeSoftware Heritage
Differential D3027

Fix "make check" issues and upgrade npm dependencies
ClosedPublic
Actions

Authored by anlambert on Apr 17 2020, 4:08 PM.

Details

Reviewers
olasd
Group Reviewers
Reviewers
Commits
rDWAPPS1427f48610ab: package.json: Upgrade depencies
rDWAPPSb76fa13a4fa1: cypress/utils: Fix eslint warning
rDWAPPS8db7f4203a66: pre-commit-config: Globally exclude tests resources file tree
Summary

That diff contains three small commits:

  • pre-commit-config: Globally exclude tests resources file tree (make check fails otherwise)
  • cypress/utils: Fix eslint warning (spotted with make check)
  • package.json: Upgrade depencies (notably upgrade jQuery to 3.5 and use recommended dompurify option)

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Apr 17 2020, 4:08 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptApr 17 2020, 4:08 PM
swh-public-ci added a comment.Apr 17 2020, 4:17 PM

Build has FAILED

Patch application report for D3027 (id=10752)

Rebasing onto 533628aa89...

Current branch diff-target is up to date.
Changes applied before test
commit 88a6d76c2bbbd0161d635f7c4f95f9eecc314c9d
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Apr 16 18:21:27 2020 +0200

    package.json: Upgrade depencies
    
    Notably upgrade jQuery to 3.5 and use recommended dompurify option.

commit 063a1c45176ff14efeeaae7ad1e5ae72d961278d
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Apr 16 17:15:56 2020 +0200

    cypress/utils: Fix eslint warning

commit b15407b4ba9b9065edb9e2c8f6fd965e99b8eddc
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Apr 16 17:14:23 2020 +0200

    pre-commit-config: Globally exclude tests resources file tree

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/63/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/63/console

Harbormaster failed remote builds in B11871: Diff 10752!Apr 17 2020, 4:17 PM
swh-public-ci added a comment.Apr 17 2020, 4:26 PM

Build is green

Patch application report for D3027 (id=10752)

Rebasing onto 533628aa89...

Current branch diff-target is up to date.
Changes applied before test
commit 88a6d76c2bbbd0161d635f7c4f95f9eecc314c9d
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Apr 16 18:21:27 2020 +0200

    package.json: Upgrade depencies
    
    Notably upgrade jQuery to 3.5 and use recommended dompurify option.

commit 063a1c45176ff14efeeaae7ad1e5ae72d961278d
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Apr 16 17:15:56 2020 +0200

    cypress/utils: Fix eslint warning

commit b15407b4ba9b9065edb9e2c8f6fd965e99b8eddc
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Apr 16 17:14:23 2020 +0200

    pre-commit-config: Globally exclude tests resources file tree

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/64/ for more details.

Harbormaster completed remote builds in B11871: Diff 10752.Apr 17 2020, 4:26 PM
olasd accepted this revision.Apr 17 2020, 4:59 PM
This revision is now accepted and ready to land.Apr 17 2020, 4:59 PM
anlambert updated this revision to Diff 10753.Apr 17 2020, 5:04 PM

Rebase

This revision was landed with ongoing or failed builds.Apr 17 2020, 5:04 PM
Closed by commit rDWAPPS8db7f4203a66: pre-commit-config: Globally exclude tests resources file tree (authored by anlambert). · Explain Why
This revision was automatically updated to reflect the committed changes.
anlambert added a commit: rDWAPPS8db7f4203a66: pre-commit-config: Globally exclude tests resources file tree.
anlambert added a commit: rDWAPPSb76fa13a4fa1: cypress/utils: Fix eslint warning.
anlambert added a commit: rDWAPPS1427f48610ab: package.json: Upgrade depencies.
swh-public-ci added a comment.Apr 17 2020, 5:13 PM

Build is green

Patch application report for D3027 (id=10753)

Rebasing onto 1427f48610...

First, rewinding head to replay your work on top of it...
Fast-forwarded diff-target to base-revision-65-D3027.
Changes applied before test



See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/65/ for more details.
Harbormaster completed remote builds in B11881: Diff 10753.Apr 17 2020, 5:13 PM
Revision Contents
Changeset List
Diff 10754
View Options
.pre-commit-config.yaml
Loading...
About · Developer information · Legal