Is this already covered by current tests?

Rebase on latest code

"Missing" isn't perfect, maybe, but it's consistent with SQL storage tables at least.

awesome ;)

No need for data disk

You terraform log says "Standard_B2s", but the diff requests Standard_D8Sv3. How come?

• Rename vaultNicConfiguration to storageNicConfiguration
• Use vm size same as storage0.euwest: Standard_D8Sv3

Add both admin keys to authorized_keys

and swh-storage debian package built [1] (passing the cassandra tests ;)

Only provide one public key block

comparing only 2 jenkins build runs, there is a gain of ~10s
0:03:35 (here) instead of 0:03:44 (previous diff which got merged).

well, if we can truncate, that sounds simpler and clearer indeed ;)

Improve sentence phrasing

Build has FAILED

and apologies for the delay.

Worth a try i guess.

I'm guessing it's missing the corresponding cypress test scenario.

The pytest tests are succeeding in the swh-indexer module, but failing in some other modules. Since this issue pertains to only the swh-indexer module, it shouldn't cause problems, right?

Looks good.

Also there is a CONTRIBUTOR file at the top-level where you could add yourself to.

ok then.

As it's in core though, I'm unsure about the impacts so if someone else could review as well, that'd be neat.

Improve initialization and docstring

Remove spurious check and align variable name

• test_model: Simplify and align model checks

Remove spurious check

Improve checks

A CI job is building a sources.json every day! The file is available at https://nix-community.github.io/nixpkgs-swh/sources.json ;)

This is a community CI (not hosted on main NixOS infrastructure) which will allow me to iterate quickly on this file.

Fail ingestion with a proper message if at least 1 artifact has no upload time

I think in last resort we could extract the missing date from the creation date of the top-level directory

contained in the downloaded tarball. This directory is created when uploading a package to the npm
registry when calling npm publish.

Looks good regarding the scope of that diff !

cool

done indeed.

I'll try to install a corresponding version.
yes, that works, now need to do this in puppet dsl though...

Heads up.

What about updating the data model to allow missing dates?

In revision?

Yes

Improve warning log message in case of no time is provided

I don't think it's a good idea to silently skip artifacts like this.

Landed.

Move the cassandra storage's dependencies to a profile

landed

accepted, will land it soon.

you're making the cassandra driver in the same process as the webapp. Are you sure you want to do that?

Fix crash of Cassandra on Java >=9