Page MenuHomeSoftware Heritage

model: Update revision date types to be optional
ClosedPublic

Authored by ardumont on Thu, Jan 30, 3:40 PM.

Diff Detail

Repository
rDMOD Data Model
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Thu, Jan 30, 3:40 PM
vlorentz requested changes to this revision.Thu, Jan 30, 4:07 PM
vlorentz added a subscriber: vlorentz.
vlorentz added inline comments.
swh/model/tests/test_model.py
102

should compare its value

This revision now requires changes to proceed.Thu, Jan 30, 4:07 PM
ardumont updated this revision to Diff 9321.Thu, Jan 30, 4:31 PM

Improve checks

vlorentz accepted this revision.Thu, Jan 30, 4:35 PM
vlorentz added inline comments.
swh/model/tests/test_model.py
102

You can remove this assertion now, it's redundant because of the last one

This revision is now accepted and ready to land.Thu, Jan 30, 4:35 PM
ardumont updated this revision to Diff 9322.Thu, Jan 30, 4:38 PM

Remove spurious check

ardumont added inline comments.Thu, Jan 30, 4:41 PM
swh/model/tests/test_model.py
102

yes but i somehow kept it to be consistent with the other checks...

ardumont updated this revision to Diff 9323.Thu, Jan 30, 4:42 PM
  • test_model: Simplify and align model checks
ardumont updated this revision to Diff 9324.Thu, Jan 30, 4:44 PM

Remove spurious check and align variable name