Differential D2615

Make tests reuse the same keyspace/schema instead of recreating it for each test.
ClosedPublic
Actions

Authored by vlorentz on Feb 3 2020, 12:26 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDSTO25941d52e3b1: Make tests reuse the same keyspace/schema instead of recreating it for each…

Summary

This makes tests run 16 times faster than D2612
(which is itself 3 times faster than this commit's parent)

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Feb 3 2020, 12:26 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 3 2020, 12:26 PM

vlorentz mentioned this in D2612: Add a keyspace_queue fixture to prepare keyspaces concurrently..Feb 3 2020, 12:26 PM

better commit message

vlorentz edited the summary of this revision. (Show Details)Feb 3 2020, 12:28 PM

well, if we can truncate, that sounds simpler and clearer indeed ;)

ardumont accepted this revision.Feb 3 2020, 12:29 PM

This revision is now accepted and ready to land.Feb 3 2020, 12:29 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/954/ for more details.

Harbormaster completed remote builds in B10414: Diff 9352.Feb 3 2020, 12:39 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/955/ for more details.

Harbormaster completed remote builds in B10415: Diff 9353.Feb 3 2020, 12:48 PM

Closed by commit rDSTO25941d52e3b1: Make tests reuse the same keyspace/schema instead of recreating it for each… (authored by vlorentz). · Explain WhyFeb 3 2020, 1:12 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDSTO25941d52e3b1: Make tests reuse the same keyspace/schema instead of recreating it for each….

Revision Contents
Changeset List

Path

Size

swh/

storage/

cassandra/

schema.py

6 lines

tests/

test_cassandra.py

20 lines

Diff 9354

View Options

swh/storage/cassandra/schema.py