Page MenuHomeSoftware Heritage
Differential D2608

indexer.tests: Use module's `get_<storage-backend>` to instantiate backend
ClosedPublic
Actions

Authored by ardumont on Jan 31 2020, 9:35 AM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDCIDXc018eeaaf7cb: conftest: Use module's `get_<storage-backend>` to instantiate backend
Summary

Instead of directly import the storage backend whose name could change.

This fixes the ci build [1]

[1] https://jenkins.softwareheritage.org/job/DCIDX/job/tests/817/console

Test Plan

tox

Unsure of the result yet as another error is entangled within.
Meaning the build will fail as long as the other error is not fixed.

Diff Detail

Repository
rDCIDX Metadata indexer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Jan 31 2020, 9:35 AM
swh-public-ci added a comment.Jan 31 2020, 9:37 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/669/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/669/console

Harbormaster failed remote builds in B10392: Diff 9327!Jan 31 2020, 9:37 AM
ardumont updated this revision to Diff 9328.EditedJan 31 2020, 9:41 AM

Improve initialization and docstring

ardumont edited the test plan for this revision. (Show Details)Jan 31 2020, 9:42 AM
swh-public-ci added a comment.Jan 31 2020, 9:43 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/670/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/670/console

Harbormaster failed remote builds in B10393: Diff 9328!Jan 31 2020, 9:43 AM
ardumont retitled this revision from conftest: Use module's `get_<storage-backend>` to instantiate backend to indexer.tests: Use module's `get_<storage-backend>` to instantiate backend.Jan 31 2020, 9:45 AM
vlorentz accepted this revision.Jan 31 2020, 11:27 AM
This revision is now accepted and ready to land.Jan 31 2020, 11:27 AM
vlorentz added a child revision: D2609: Move IndexerStorage documentation and endpoint paths to a new IndexerStorageInterface class..Jan 31 2020, 11:49 AM
This revision was landed with ongoing or failed builds.Jan 31 2020, 12:02 PM
Closed by commit rDCIDXc018eeaaf7cb: conftest: Use module's `get_<storage-backend>` to instantiate backend (authored by ardumont). · Explain Why
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDCIDXc018eeaaf7cb: conftest: Use module's `get_<storage-backend>` to instantiate backend.

Revision Contents
Changeset List

PathSize
swh/
indexer/
tests/
40 lines

Diff 9330

View Options

swh/indexer/tests/conftest.py

Loading...
About · Developer information · Legal