Monkey-patch backend classes instead of 'get_storage' functions.
ClosedPublic
Actions

Authored by vlorentz on Jan 31 2020, 1:26 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDCIDX15811b949295: Monkey-patch backend classes instead of 'get_storage' functions.

Summary

get_storage functions are usually imported from X import get_storage,
so monkey-patching X.get_storage has no effect.
This commit reverts the behavior change introduced in
c018eeaaf7cb862402608426b90e9c7609a4a418.

Diff Detail

Repository

rDCIDX Metadata indexer

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jan 31 2020, 1:26 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 31 2020, 1:26 PM

ardumont accepted this revision.Jan 31 2020, 1:27 PM

This revision is now accepted and ready to land.Jan 31 2020, 1:27 PM

ok then.

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/673/ for more details.

Harbormaster completed remote builds in B10399: Diff 9338.Jan 31 2020, 1:28 PM

Closed by commit rDCIDX15811b949295: Monkey-patch backend classes instead of 'get_storage' functions. (authored by vlorentz). · Explain WhyJan 31 2020, 1:30 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDCIDX15811b949295: Monkey-patch backend classes instead of 'get_storage' functions..

Revision Contents
Changeset List

Path

Size

swh/

indexer/

tests/

conftest.py

8 lines

Diff 9339

View Options

swh/indexer/tests/conftest.py

Monkey-patch backend classes instead of 'get_storage' functions.ClosedPublicActions