sorry for the glitch

In D2427#57372, @ardumont wrote:

tests should pass ok however no test exists for the interaction with the
scheduler, so...

By adding the swh_scheduler fixture in one test (which adds a deposit), you could either:

• check the check_task_id, load_task_id are set

• introspect the swh_scheduler.search_task('check-deposit') tasks to ensure there is something [1]

[1] https://forge.softwareheritage.org/source/swh-lister/browse/master/swh/lister/cgit/tests/test_lister.py$53-55

add X-Forwarded-Host header and configure allowed_hosts as '*'

prometheus_client looks quite low-level to me. We already have statsd for this kind of purpose, which does not imply having to deal with one more dedicated http server or so...

Sorry I'm commenting this a bit late, but wouldn't it make more sense to have something like:

rebased

move statsd emv var declarations in an env/statsd.env file and use it on swh-web

In D2416#57093, @anlambert wrote:

Great ! Could you also add that configuration to the swh-web service ? I am currently working on T2124 and I have added a couple of statsd metric to the webapp.

rebase

rebase

rebased

rebased

forgot a few matches, as noticed by anlambert

In D2413#57044, @anlambert wrote:

I totally agree on this. You miss some replacements in the tests and the README though.

Okay I see no "simple" way of doing this with the current implementation of tasks using SWHTask.

Closed by D2394

LGTM

ok, let's keep _scheduler_ in probe names

I said -scheduler !

rebased + rename statsd probes (-scheduler/+total)

rebased

LGTM but I'm not very used to the webapp's code.

looks very good to me, thanks!

Not very fond, but will work and remains the simplest solution.

Closed by 9a98e8be06817055693671cfbe6917645171993e