Page MenuHomeSoftware Heritage

Enable Sentry for CLIs, and Gunicorn and Celery workers.
ClosedPublic

Authored by vlorentz on Dec 10 2019, 2:53 PM.

Diff Detail

Repository
rDENV Development environment
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Dec 10 2019, 2:53 PM
vlorentz updated this revision to Diff 8579.Dec 10 2019, 2:56 PM

add comment

ardumont added inline comments.
docker/env/common_python.env
6

why is it empty?

ardumont added inline comments.Dec 10 2019, 2:58 PM
docker/env/common_python.env
6

Because no sentry in the docker env?

vlorentz added inline comments.Dec 10 2019, 2:58 PM
docker/env/common_python.env
6

We decided against running Sentry in our Docker env, it's too big and too niche. Instead, you should run it on your own.

ardumont added inline comments.Dec 10 2019, 3:05 PM
docker/env/common_python.env
6

ack.

But why do we need to specify this if this is empty?

ardumont accepted this revision.Dec 10 2019, 3:06 PM
This revision is now accepted and ready to land.Dec 10 2019, 3:06 PM
vlorentz added inline comments.Dec 10 2019, 3:28 PM
docker/env/common_python.env
6

We don't need to.

vlorentz updated this revision to Diff 8580.Dec 10 2019, 3:29 PM

comment out SWH_SENTRY_DSN.

vlorentz marked 3 inline comments as done.Dec 10 2019, 3:29 PM
vlorentz retitled this revision from [WIP] Enable Sentry for CLIs and Gunicorn workers. to Enable Sentry for CLIs and Gunicorn workers..
vlorentz updated this revision to Diff 8588.Dec 11 2019, 2:00 PM

add documentation.

douardda added inline comments.
docker/docker-compose.yml
270

? swh-deposit-api is now swh-scheduler

olasd accepted this revision.Dec 11 2019, 2:10 PM
vlorentz updated this revision to Diff 8590.Dec 11 2019, 2:11 PM

fix rebase

vlorentz added inline comments.Dec 11 2019, 2:11 PM
docker/docker-compose.yml
270

oops, I messed up my rebase

vlorentz retitled this revision from Enable Sentry for CLIs and Gunicorn workers. to Enable Sentry for CLIs, and Gunicorn and Celery workers..Dec 11 2019, 2:12 PM
This revision was automatically updated to reflect the committed changes.