Page MenuHomeSoftware Heritage

Lister monitoring: add statsd probe for each lister instance
Open, NormalPublic

Description

Generalize T2119 with probes for every lister *instance* instead of every lister *type*, to allow monitoring for every individual upstream source.

Related Objects

Event Timeline

olasd created this task.Dec 2 2019, 2:13 PM
vlorentz triaged this task as High priority.Dec 3 2019, 3:17 PM
vlorentz lowered the priority of this task from High to Normal.Dec 3 2019, 5:50 PM
douardda added a subscriber: douardda.EditedDec 9 2019, 12:32 PM

Okay I see no "simple" way of doing this with the current implementation of tasks using SWHTask.

The information needed (the "instance") is computed in the constructor of the lister itself, so there is no way we can retrieve this information in SWHTask.__call__().

The only sensible place where this probe could be inserted is thus within the Lister code (constructor or probably better in the run() method).

So it cannot be the same probes as the ones in SWHTask (aka 'swh_task_start_ts' and 'swh_task_end_ts') with added tags.