Details
Details
- Reviewers
anlambert - Group Reviewers
Reviewers - Commits
- rDJNL0177a9272bbe: replay: ensure a revision is present only once in a batch
Diff Detail
Diff Detail
- Repository
- rDJNL Journal infrastructure
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DJNL/job/tox/309/
See console output for more information: https://jenkins.softwareheritage.org/job/DJNL/job/tox/309/console
| swh/journal/replay.py | ||
|---|---|---|
| 78 | I would rather use for rev in set(revisions): to remove duplicates but I don't know if the original revision ordering matters here. | |
| swh/journal/replay.py | ||
|---|---|---|
| 78 | The order matters, and (ideally) we need to keep only the last version of the object. I guess the easiest solution is to put the revisions in a dict keyed by id, and return the values() of that dict. | |