Page MenuHomeSoftware Heritage

Rename swh-scheduler-api as swh-scheduler and swh-vault-api as swh-vault
ClosedPublic

Authored by douardda on Dec 9 2019, 4:23 PM.

Details

Summary

It makes no sense to have -api postfixes for these 2 services only.
Plus, these are not API endpoints but RPC ones.

Diff Detail

Repository
rDENV Development environment
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Dec 9 2019, 4:23 PM
ardumont accepted this revision.Dec 9 2019, 4:24 PM
ardumont added a subscriber: ardumont.

Indeed.

This revision is now accepted and ready to land.Dec 9 2019, 4:24 PM
anlambert requested changes to this revision.EditedDec 9 2019, 4:27 PM
anlambert added a subscriber: anlambert.

I totally agree on this. You miss some replacements in the tests and the README though.

This revision now requires changes to proceed.Dec 9 2019, 4:27 PM

I totally agree on this. You miss some replacements in the tests and the README though.

oopsie, thanks

douardda updated this revision to Diff 8538.Dec 9 2019, 4:34 PM

forgot a few matches, as noticed by anlambert

anlambert accepted this revision.Dec 9 2019, 4:38 PM

All good !

This revision is now accepted and ready to land.Dec 9 2019, 4:38 PM