Page MenuHomeSoftware Heritage
Feed All Stories

Nov 29 2022

vlorentz requested review of D8898: Add Luigi to requirements of swh-dataset and swh-graph.
Nov 29 2022, 3:38 PM
ardumont added inline comments to D8888: Drop content_language and content_ctags tables and related SQL functions.
Nov 29 2022, 3:38 PM
vlorentz committed rDGRPHb10f126bb47a: luigi: Fix typo in docstring (authored by vlorentz).
luigi: Fix typo in docstring
Nov 29 2022, 3:32 PM
anlambert updated the diff for D8890: metrics: Add gauge counting save origin requests created from webhooks.

Drop visit_type label in prometheus gauge.

Nov 29 2022, 3:31 PM
vlorentz committed rDCIDX3faeac6cb667: docs: Remove remaining references to ctags and content_language (authored by vlorentz).
docs: Remove remaining references to ctags and content_language
Nov 29 2022, 3:31 PM
anlambert updated the diff for D8889: save_code_now: Add from_webhook field to SaveOriginRequest model.

Fix docstring

Nov 29 2022, 3:30 PM
vlorentz closed D8888: Drop content_language and content_ctags tables and related SQL functions.
Nov 29 2022, 3:28 PM
vlorentz committed rDCIDXa5ee54aedece: Drop content_language and content_ctags tables and related SQL functions (authored by vlorentz).
Drop content_language and content_ctags tables and related SQL functions
Nov 29 2022, 3:28 PM
olasd added inline comments to D8888: Drop content_language and content_ctags tables and related SQL functions.
Nov 29 2022, 3:28 PM
anlambert added inline comments to D8890: metrics: Add gauge counting save origin requests created from webhooks.
Nov 29 2022, 3:24 PM
vlorentz committed rDGRPHd08d6059ce58: luigi: Add missing docstrings (authored by vlorentz).
luigi: Add missing docstrings
Nov 29 2022, 3:24 PM
olasd added inline comments to D8890: metrics: Add gauge counting save origin requests created from webhooks.
Nov 29 2022, 3:17 PM
swh-public-ci added a comment to D8890: metrics: Add gauge counting save origin requests created from webhooks.

Build is green

Nov 29 2022, 3:16 PM
swh-public-ci added a comment to D8889: save_code_now: Add from_webhook field to SaveOriginRequest model.

Build is green

Nov 29 2022, 3:14 PM
olasd added inline comments to D8889: save_code_now: Add from_webhook field to SaveOriginRequest model.
Nov 29 2022, 3:11 PM
anlambert updated the diff for D8890: metrics: Add gauge counting save origin requests created from webhooks.

Update: Add label for webhook origin in prometheus gauge

Nov 29 2022, 3:04 PM
anlambert updated the diff for D8889: save_code_now: Add from_webhook field to SaveOriginRequest model.

Update: also add column in save_origin_requests table indicating which forge type sent the webhook

Nov 29 2022, 3:03 PM
zack committed rMSLD13283bc2040e: check-in slides for IFRI panel about FOSS geopolitics (authored by zack).
check-in slides for IFRI panel about FOSS geopolitics
Nov 29 2022, 2:49 PM
ardumont added inline comments to D8882: replay: Do not ignore externals in copyfrom operations.
Nov 29 2022, 2:27 PM
vlorentz committed rDGRPH48fca3afc213: luigi: Fix typos in docstring (authored by vlorentz).
luigi: Fix typos in docstring
Nov 29 2022, 2:22 PM
ardumont accepted D8888: Drop content_language and content_ctags tables and related SQL functions.

one question to team inline.

Nov 29 2022, 2:15 PM
vlorentz closed D8896: luigi: Rename classes to be globally unambiguous.
Nov 29 2022, 2:10 PM
vlorentz committed rDDATASET99a599378f29: luigi: Rename classes to be globally unambiguous (authored by vlorentz).
luigi: Rename classes to be globally unambiguous
Nov 29 2022, 2:10 PM
anlambert added a comment to D8889: save_code_now: Add from_webhook field to SaveOriginRequest model.

And would it make sense to store which webhook was used?

It can be easily guessed from the origin URL so I do not think we should add that info.

How? That works for Bitbucket and GitHub, but you can't tell whether "git.example.org" is Gitlab or Gitea

Nov 29 2022, 2:02 PM
anlambert added a comment to D8886: replay: Add more debug logs.

@anlambert Looks like you should use a separate logger, so it integrates with the standard logging config, eg.

swh -l DEBUG -l swh.loader.svn.whatever:INFO loader run svn <repo_url>

to have all debug logs except from the swh.loader.svn.whatever logger

Nov 29 2022, 1:55 PM
vlorentz added a comment to D8886: replay: Add more debug logs.

@anlambert Looks like you should use a separate logger, so it integrates with the standard logging config, eg.

Nov 29 2022, 1:48 PM
swh-public-ci added a comment to D8897: Change the input type in contentByHashes entrypoint.

Build is green

Nov 29 2022, 1:34 PM
jayeshv added inline comments to D8897: Change the input type in contentByHashes entrypoint.
Nov 29 2022, 1:34 PM
vlorentz added a comment to D8889: save_code_now: Add from_webhook field to SaveOriginRequest model.

And would it make sense to store which webhook was used?

It can be easily guessed from the origin URL so I do not think we should add that info.

Nov 29 2022, 1:34 PM
jayeshv updated the diff for D8897: Change the input type in contentByHashes entrypoint.

address review comments

Nov 29 2022, 1:31 PM
anlambert added a comment to D8889: save_code_now: Add from_webhook field to SaveOriginRequest model.

What is it going to be used for?

To compute some stats about usage of that feature.

And would it make sense to store which webhook was used?

It can be easily guessed from the origin URL so I do not think we should add that info.

Nov 29 2022, 1:21 PM
ardumont abandoned D8831: Merge gitlab tools to manage groups and projects into a unified cli.

Landed through 23b3255c3cbd3deed8c7865ae1d1ca7045bdd386

Nov 29 2022, 12:36 PM
ardumont accepted D8886: replay: Add more debug logs.

Makes sense.

Nov 29 2022, 12:31 PM
lunar added inline comments to D8897: Change the input type in contentByHashes entrypoint.
Nov 29 2022, 12:31 PM
anlambert added a comment to D8889: save_code_now: Add from_webhook field to SaveOriginRequest model.

What is it going to be used for?

Nov 29 2022, 12:26 PM
anlambert added a comment to D8886: replay: Add more debug logs.
In D8886#231281, @lunar wrote:

Could you explain why using loglevels would not work? It feels to me they are meant to solve the problem of selecting the appropriate amount of debug messages… Having a separate flag introduce quite some extra noise in the process.

Nov 29 2022, 12:23 PM
jayeshv requested review of D8897: Change the input type in contentByHashes entrypoint.
Nov 29 2022, 12:18 PM
ardumont added a comment to D8889: save_code_now: Add from_webhook field to SaveOriginRequest model.

What is it going to be used for?

Nov 29 2022, 12:14 PM
lunar added a comment to D8886: replay: Add more debug logs.

Could you explain why using loglevels would not work? It feels to me they are meant to solve the problem of selecting the appropriate amount of debug messages… Having a separate flag introduce quite some extra noise in the process.

Nov 29 2022, 12:11 PM
Harbormaster failed to build B33008: rDGRPH60e4707feca6: Add luigi task to compress the graph for rDGRPH60e4707feca6: Add luigi task to compress the graph!
Nov 29 2022, 12:01 PM
ardumont accepted D8890: metrics: Add gauge counting save origin requests created from webhooks.
Nov 29 2022, 11:56 AM
lunar added a comment to D8314: add a documentation landing page.

See D8894 for an alternative implementation.

Nov 29 2022, 11:56 AM
ardumont accepted D8896: luigi: Rename classes to be globally unambiguous.
Nov 29 2022, 11:55 AM
vlorentz committed rDGRPH2b634bf4192d: luigi: Simplify compression task (authored by vlorentz).
luigi: Simplify compression task
Nov 29 2022, 11:54 AM
vlorentz committed rDGRPH0a4b706400d4: luigi: Remove option to configure graph name (authored by vlorentz).
luigi: Remove option to configure graph name
Nov 29 2022, 11:54 AM
vlorentz closed D8891: Add luigi task to compress the graph.
Nov 29 2022, 11:54 AM
vlorentz committed rDGRPH60e4707feca6: Add luigi task to compress the graph (authored by vlorentz).
Add luigi task to compress the graph
Nov 29 2022, 11:54 AM
ardumont accepted D8891: Add luigi task to compress the graph.
Nov 29 2022, 11:51 AM
vlorentz requested review of D8896: luigi: Rename classes to be globally unambiguous.
Nov 29 2022, 11:49 AM
swh-public-ci added a comment to D8891: Add luigi task to compress the graph.

Build is green

Nov 29 2022, 11:30 AM
vlorentz updated the diff for D8891: Add luigi task to compress the graph.

fix setup.py and doc

Nov 29 2022, 11:23 AM
Harbormaster failed remote builds in B33005: Diff 32059 for D8891: Add luigi task to compress the graph!
Nov 29 2022, 11:17 AM
swh-public-ci added a comment to D8891: Add luigi task to compress the graph.

Build has FAILED

Nov 29 2022, 11:17 AM
vlorentz updated the diff for D8891: Add luigi task to compress the graph.

fix tox.ini + remove option to configure graph name

Nov 29 2022, 11:14 AM
Harbormaster failed remote builds in B33004: Diff 32058 for D8891: Add luigi task to compress the graph!
Nov 29 2022, 11:10 AM
swh-public-ci added a comment to D8891: Add luigi task to compress the graph.

Build has FAILED

Nov 29 2022, 11:10 AM
vlorentz updated the diff for D8891: Add luigi task to compress the graph.
  • luigi: Simplify compression task
Nov 29 2022, 11:06 AM
olasd committed rDPROVc46d896cd651: Drop denormalized db flavor (authored by olasd).
Drop denormalized db flavor
Nov 29 2022, 11:02 AM
olasd committed rDPROV9b0dca6f5a6f: Make direct archive DSN a string instead of a dict (authored by olasd).
Make direct archive DSN a string instead of a dict
Nov 29 2022, 11:02 AM
olasd committed rDPROV5cfe3d3cb67d: Make postgresql storage DSN a string instead of a dict (authored by olasd).
Make postgresql storage DSN a string instead of a dict
Nov 29 2022, 11:02 AM
ardumont committed rDSNIP23b3255c3cbd: Merge gitlab tools to manage groups and projects into a unified cli (authored by ardumont).
Merge gitlab tools to manage groups and projects into a unified cli
Nov 29 2022, 11:01 AM
ardumont closed D8874: Dockerfile: Reference the rsvndump binary in /usr/local/bin/rsvndump.
Nov 29 2022, 10:18 AM
ardumont committed rDENVaa418ac16f58: Dockerfile: Reference the rsvndump binary in /usr/local/bin/rsvndump (authored by ardumont).
Dockerfile: Reference the rsvndump binary in /usr/local/bin/rsvndump
Nov 29 2022, 10:18 AM
ardumont closed D8876: Dockerfile: Reference the rsvndump binary in /usr/local/bin/rsvndump.
Nov 29 2022, 10:18 AM
ardumont committed rCDFJ6c00bf379477: Dockerfile: Reference the rsvndump binary in /usr/local/bin/rsvndump (authored by ardumont).
Dockerfile: Reference the rsvndump binary in /usr/local/bin/rsvndump
Nov 29 2022, 10:18 AM
lunar closed D8895: Remove the unused dependency on sphinx-tabs.
Nov 29 2022, 10:17 AM
lunar committed rDDOCa805f6abc5b5: Remove the unused dependency on sphinx-tabs (authored by lunar).
Remove the unused dependency on sphinx-tabs
Nov 29 2022, 10:17 AM
ardumont accepted D8895: Remove the unused dependency on sphinx-tabs.
Nov 29 2022, 10:11 AM
lunar requested review of D8895: Remove the unused dependency on sphinx-tabs.
Nov 29 2022, 9:30 AM

Nov 28 2022

lunar requested review of D8894: WIP Implement a landing page for the documentation.
Nov 28 2022, 5:53 PM
lunar closed D8887: Migrate to sphinx-design.
Nov 28 2022, 5:46 PM
lunar committed rDDOCefc955759316: Migrate to sphinx-design (authored by lunar).
Migrate to sphinx-design
Nov 28 2022, 5:46 PM
vlorentz requested review of D8891: Add luigi task to compress the graph.

tests will pass when swh-dataset is released

Nov 28 2022, 5:34 PM
olasd triaged T4707: provenance: add (revision) dates to the relation tables as High priority.
Nov 28 2022, 4:56 PM · Provenance database
olasd created T4707: provenance: add (revision) dates to the relation tables.
Nov 28 2022, 4:55 PM · Provenance database
olasd triaged T4706: provenance: consider running the origin->revision provenance algorithm on only "releases" as Normal priority.
Nov 28 2022, 4:46 PM · Provenance database
vlorentz added a revision to T2220: swh-graph in production: D8891: Add luigi task to compress the graph.
Nov 28 2022, 4:34 PM · Roadmap 2022, meta-task, Roadmap 2021, Compressed graph service
anlambert committed rCJSWH4fd2920268ae: templates/stage-cypress-tests: Use a local temporary cypress cache (authored by anlambert).
templates/stage-cypress-tests: Use a local temporary cypress cache
Nov 28 2022, 3:42 PM
vlorentz added a comment to D8889: save_code_now: Add from_webhook field to SaveOriginRequest model.

What is it going to be used for?

Nov 28 2022, 3:42 PM
vlorentz requested review of D8888: Drop content_language and content_ctags tables and related SQL functions.
Nov 28 2022, 3:42 PM
anlambert requested review of D8890: metrics: Add gauge counting save origin requests created from webhooks.
Nov 28 2022, 3:28 PM
anlambert added a revision to T4548: Add a public API endpoint and documentation to trigger Save Code Now from webhook: D8890: metrics: Add gauge counting save origin requests created from webhooks.
Nov 28 2022, 3:17 PM · Web app
anlambert requested review of D8889: save_code_now: Add from_webhook field to SaveOriginRequest model.
Nov 28 2022, 3:15 PM
anlambert added a revision to T4548: Add a public API endpoint and documentation to trigger Save Code Now from webhook: D8889: save_code_now: Add from_webhook field to SaveOriginRequest model.
Nov 28 2022, 2:09 PM · Web app
olasd added a comment to T4701: GitHub mirror of swh-graph is not updated.

(I've at least pushed the main branch and relevant tags)

Nov 28 2022, 2:00 PM · System administration, Compressed graph service
olasd added a comment to T4701: GitHub mirror of swh-graph is not updated.

As I've suspected, this is due to the pristine-tar branch having objects that exceed 100MB:

Nov 28 2022, 1:58 PM · System administration, Compressed graph service
vlorentz added inline comments to D8873: storage: Insert from temporary tables in consistent order.
Nov 28 2022, 12:34 PM
vlorentz closed D8873: storage: Insert from temporary tables in consistent order.
Nov 28 2022, 12:33 PM
vlorentz committed rDCIDXf7833b7e2d98: storage: Insert from temporary tables in consistent order (authored by vlorentz).
storage: Insert from temporary tables in consistent order
Nov 28 2022, 12:33 PM
vlorentz accepted D8887: Migrate to sphinx-design.

ooh, I should use this on https://docs.softwareheritage.org/devel/swh-graph/grpc-api.html too

Nov 28 2022, 12:29 PM
lunar requested review of D8887: Migrate to sphinx-design.
Nov 28 2022, 12:19 PM
Harbormaster failed to build B32986: rDGRPH6572c43136fd: Fix linting for rDGRPH6572c43136fd: Fix linting!
Nov 28 2022, 12:14 PM
vlorentz committed rDGRPH6572c43136fd: Fix linting (authored by vlorentz).
Fix linting
Nov 28 2022, 12:08 PM
vlorentz reopened T4549: Write a script to generate qualified SWHID from swh-graph as "Open".

We should add some tests so the code doesn't break when we change other stuff. I'll try to do it this week

Nov 28 2022, 11:08 AM · Compressed graph service
swh-public-ci added a comment to D8873: storage: Insert from temporary tables in consistent order.

Build is green

Nov 28 2022, 11:04 AM
vlorentz added inline comments to D8873: storage: Insert from temporary tables in consistent order.
Nov 28 2022, 11:00 AM
vlorentz updated the diff for D8873: storage: Insert from temporary tables in consistent order.

bump schema version and add migration

Nov 28 2022, 11:00 AM
douardda triaged T4704: Publish objects that has been subject to a TDN in a (series of) kafka topic as High priority.
Nov 28 2022, 10:57 AM · Roadmap 2022, meta-task, Roadmap 2021, Web app
anlambert closed T4698: Error when requesting vault cooking for a directory in pending state as Resolved.

Fixed and deployed.

Nov 28 2022, 10:55 AM · Web app
douardda added a comment to T4657: Allow object removal from journal.
In T4657#98361, @lunar wrote:

[...]
@douardda: would you agree?

Nov 28 2022, 10:52 AM · Journal