Differential D8896

luigi: Rename classes to be globally unambiguous
ClosedPublic
Actions

Authored by vlorentz on Nov 29 2022, 11:47 AM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDDATASET99a599378f29: luigi: Rename classes to be globally unambiguous

Summary

Otherwise, UploadToS3, DownloadToS3, and RunAll would conflict with
tasks about to be defined in swh.graph; and Luigi requires task names
to be globally unique.

Diff Detail

Repository

rDDATASET Datasets

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Nov 29 2022, 11:47 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 29 2022, 11:47 AM

Build is green

Patch application report for D8896 (id=32061)

Rebasing onto f8a13718b6...

Current branch diff-target is up to date.

Changes applied before test

commit 99a599378f29f93b74f6ed86260369fddadc038d
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Nov 29 11:47:05 2022 +0100

    luigi: Rename classes to be globally unambiguous
    
    Otherwise, UploadToS3, DownloadToS3, and RunAll would conflict with
    tasks about to be defined in swh.graph; and Luigi requires task names
    to be globally unique.

See https://jenkins.softwareheritage.org/job/DDATASET/job/tests-on-diff/170/ for more details.

Harbormaster completed remote builds in B33007: Diff 32061.Nov 29 2022, 11:49 AM

vlorentz requested review of this revision.Nov 29 2022, 11:49 AM

ardumont accepted this revision.Nov 29 2022, 11:55 AM

This revision is now accepted and ready to land.Nov 29 2022, 11:55 AM

Closed by commit rDDATASET99a599378f29: luigi: Rename classes to be globally unambiguous (authored by vlorentz). · Explain WhyNov 29 2022, 2:10 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDDATASET99a599378f29: luigi: Rename classes to be globally unambiguous.