Page MenuHomeSoftware Heritage
Feed Advanced Search

Mar 30 2022

anlambert added inline comments to D6640: Add a button to the deposit admin UI to show deposit metadata.
Mar 30 2022, 2:37 PM
anlambert closed D7468: requirements-test: Remove workarounds to fix pytest execution.
Mar 30 2022, 1:52 PM
anlambert committed rDWAPPScc4a82eb38a5: requirements-test: Remove workarounds to fix pytest execution (authored by anlambert).
requirements-test: Remove workarounds to fix pytest execution
Mar 30 2022, 1:52 PM
anlambert accepted D7451: Add missing cypress tests to 'add-forge-now' request dashboard.

Looks good to me, thanks !

Mar 30 2022, 1:51 PM
anlambert added inline comments to D7470: Modify default timeouts.
Mar 30 2022, 1:15 PM
anlambert accepted D7470: Modify default timeouts.
Mar 30 2022, 1:14 PM
anlambert requested review of D7468: requirements-test: Remove workarounds to fix pytest execution.
Mar 30 2022, 11:32 AM
anlambert accepted D7467: docs/cli: Align cli documentation toc setup.
Mar 30 2022, 11:02 AM

Mar 29 2022

anlambert retitled D7442: interface: Add new method origin_visit_get_with_statuses from interface: Add new method origin_visit_status_latest_get_all to interface: Add new method origin_visit_get_with_statuses.
Mar 29 2022, 5:35 PM
anlambert updated the diff for D7442: interface: Add new method origin_visit_get_with_statuses.

Update:

Mar 29 2022, 5:34 PM
anlambert accepted D7458: Save Code Now Admin: Use different views for each tab.
Mar 29 2022, 5:24 PM
anlambert accepted D7450: Make the timeout declaratively parametric.
Mar 29 2022, 4:50 PM
anlambert added inline comments to D7451: Add missing cypress tests to 'add-forge-now' request dashboard.
Mar 29 2022, 4:42 PM
anlambert accepted D7453: Add Forge Now: Shorten template names.
Mar 29 2022, 4:18 PM
anlambert accepted D7449: swh.web.inbound_email: Add missing __init__.py file.
Mar 29 2022, 3:15 PM
anlambert added inline comments to D7453: Add Forge Now: Shorten template names.
Mar 29 2022, 3:14 PM
anlambert requested changes to D7451: Add missing cypress tests to 'add-forge-now' request dashboard.
Mar 29 2022, 2:49 PM
anlambert accepted D7454: Save Forge Now: Fix XSS in request list.
Mar 29 2022, 2:27 PM
anlambert requested changes to D7450: Make the timeout declaratively parametric.

You are still setting a timeout of 30 minutes for all jobs.

Mar 29 2022, 1:17 PM
anlambert accepted D7428: Save Code Now: Use different views for each tab.

Looks good to me.

Mar 29 2022, 11:45 AM
anlambert accepted D7440: Fix handling of initial state of #swh-add-forge-user-filter.
Mar 29 2022, 11:44 AM
anlambert accepted D7447: docs/index: Name properly index entry.
Mar 29 2022, 10:37 AM

Mar 28 2022

anlambert closed D7444: assets/webapp.css: Disable common ligatures of Alegreya font.
Mar 28 2022, 6:04 PM
anlambert committed rDWAPPS4bc8aaf1d94b: assets/webapp.css: Disable common ligatures of Alegreya font (authored by anlambert).
assets/webapp.css: Disable common ligatures of Alegreya font
Mar 28 2022, 6:04 PM
anlambert updated the diff for D7444: assets/webapp.css: Disable common ligatures of Alegreya font.

Add comment in CSS file

Mar 28 2022, 5:48 PM
anlambert requested review of D7444: assets/webapp.css: Disable common ligatures of Alegreya font.
Mar 28 2022, 5:36 PM
anlambert closed D7443: package.json: Remove use of nodemon file watchers.
Mar 28 2022, 5:16 PM
anlambert committed rDWAPPS117c98447a29: package.json: Remove use of nodemon file watchers (authored by anlambert).
package.json: Remove use of nodemon file watchers
Mar 28 2022, 5:16 PM
anlambert requested review of D7443: package.json: Remove use of nodemon file watchers.
Mar 28 2022, 4:57 PM
anlambert added a comment to T4090: Add method to efficiently retrieve latest statuses of origin visits .

I have the feeling that, in terms of API extensibility, we'll want to be returning both the OriginVisit and its latest OriginVisitStatus.
If we don't do that, we might find ourselves in a situation where we want to combine the fields from both objects into one, which feels a bit clunky when we could just return a proper composite type.

Mar 28 2022, 4:08 PM · Storage manager
anlambert requested review of D7442: interface: Add new method origin_visit_get_with_statuses.
Mar 28 2022, 3:02 PM
anlambert added a revision to T4090: Add method to efficiently retrieve latest statuses of origin visits : D7442: interface: Add new method origin_visit_get_with_statuses.
Mar 28 2022, 2:37 PM · Storage manager
anlambert closed D7441: requirements-test: Temporarily pin django-stubs to < 1.10.0.
Mar 28 2022, 2:04 PM
anlambert committed rDWAPPSea683ca5ff19: requirements-test: Temporarily pin django-stubs to < 1.10.0 (authored by anlambert).
requirements-test: Temporarily pin django-stubs to < 1.10.0
Mar 28 2022, 2:04 PM
anlambert added a comment to D7441: requirements-test: Temporarily pin django-stubs to < 1.10.0.

I assume that's what is causing the cryptic CI errors?

Mar 28 2022, 2:03 PM
anlambert requested review of D7441: requirements-test: Temporarily pin django-stubs to < 1.10.0.
Mar 28 2022, 1:48 PM
anlambert closed D7429: keycloak: Add swh.web.admin.mailmap role.
Mar 28 2022, 11:29 AM
anlambert committed rSPSITE0cd0f485428c: keycloak: Add swh.web.admin.mailmap role (authored by anlambert).
keycloak: Add swh.web.admin.mailmap role
Mar 28 2022, 11:29 AM
anlambert closed T4060: Selecting buttons and checkboxes gives no visual feedback as Resolved.

Fixed and deployed.

Mar 28 2022, 10:53 AM · Web app
anlambert renamed T4090: Add method to efficiently retrieve latest statuses of origin visits from Add method to efficiently retrieve origin visits and their latest statuses to Add method to efficiently retrieve latest statuses of origin visits .
Mar 28 2022, 10:41 AM · Storage manager

Mar 25 2022

anlambert accepted D7438: Fix flaky test in the request dashboard spec.
Mar 25 2022, 5:57 PM
anlambert added a comment to T4091: [Add forge now] Display extra information when users list their requests.

Maybe a modal view of the particular request could be done.
Make the row clickable, once clicked, that opens a modal view into
the request details (including comments).

Mar 25 2022, 5:44 PM · Add Forge Now
anlambert accepted D7431: Allow filtering add-forge-now requests in listing view.
Mar 25 2022, 5:41 PM
anlambert added a comment to D7434: Add date-fns for better date formatting/management in the JS.

Since we are showing dates in many pages, isn't it better to have a better formatting library?

Mar 25 2022, 4:47 PM
anlambert added inline comments to D7431: Allow filtering add-forge-now requests in listing view.
Mar 25 2022, 4:15 PM
anlambert accepted D7426: Maintain tab selection on refresh.
Mar 25 2022, 3:27 PM
anlambert created P1316 (An Untitled Masterwork).
Mar 25 2022, 2:27 PM
anlambert added inline comments to D7431: Allow filtering add-forge-now requests in listing view.
Mar 25 2022, 2:23 PM
anlambert added inline comments to D7428: Save Code Now: Use different views for each tab.
Mar 25 2022, 1:58 PM
anlambert added inline comments to D7431: Allow filtering add-forge-now requests in listing view.
Mar 25 2022, 1:30 PM
anlambert accepted D7427: save-code-now: Extract the checkbox filtering into a js template.
Mar 25 2022, 12:28 PM
anlambert requested changes to D7428: Save Code Now: Use different views for each tab.

I am not against it but we should add a redirection for the old URL.

Mar 25 2022, 12:06 PM
anlambert triaged T4090: Add method to efficiently retrieve latest statuses of origin visits as Normal priority.
Mar 25 2022, 11:40 AM · Storage manager
anlambert added inline comments to D7427: save-code-now: Extract the checkbox filtering into a js template.
Mar 25 2022, 11:37 AM
anlambert requested changes to D7426: Maintain tab selection on refresh.

You still need to keep the hashchange event handler or the tabs will not be switched when playing with browser history:

Mar 25 2022, 11:35 AM
anlambert requested changes to D7427: save-code-now: Extract the checkbox filtering into a js template.

You should put the template in the utils folder instead, no need to create a new bundle for that.

Mar 25 2022, 11:10 AM
anlambert requested changes to D7426: Maintain tab selection on refresh.
Mar 25 2022, 11:07 AM
anlambert requested review of D7429: keycloak: Add swh.web.admin.mailmap role.
Mar 25 2022, 10:53 AM
anlambert accepted D7424: add-forge-now: Fix login link depending on the oidc context.
Mar 25 2022, 10:45 AM

Mar 24 2022

anlambert closed D7425: common/origin_visits: Improve get_origin_visit performance.
Mar 24 2022, 7:09 PM
anlambert committed rDWAPPSd5e3f98417d2: common/origin_visits: Improve get_origin_visit performance (authored by anlambert).
common/origin_visits: Improve get_origin_visit performance
Mar 24 2022, 7:09 PM
anlambert requested changes to D7426: Maintain tab selection on refresh.

Could you add a cypress test for this ? You can inspire from the one I wrote for save code now.

Mar 24 2022, 7:08 PM
anlambert updated the diff for D7425: common/origin_visits: Improve get_origin_visit performance.

Remove added line break in test_origin_root_directory_view

Mar 24 2022, 6:42 PM
anlambert updated the diff for D7425: common/origin_visits: Improve get_origin_visit performance.

Update:

  • address @ardumont comment
  • update years in license headers
Mar 24 2022, 6:39 PM
anlambert added inline comments to D7425: common/origin_visits: Improve get_origin_visit performance.
Mar 24 2022, 6:33 PM
anlambert requested review of D7425: common/origin_visits: Improve get_origin_visit performance.
Mar 24 2022, 5:46 PM
anlambert closed D7422: test_client: Fix failing test since recent swh-model update.
Mar 24 2022, 3:36 PM
anlambert committed rDJNL3771edbab33d: test_client: Fix failing test since recent swh-model update (authored by anlambert).
test_client: Fix failing test since recent swh-model update
Mar 24 2022, 3:36 PM
anlambert closed D7421: docker/conf/celery: Disable broker hearbeats.
Mar 24 2022, 3:36 PM
anlambert committed rDENV6e11bcdd2bd0: docker/tox: Replace testinfra dependency by pytest-testinfra (authored by anlambert).
docker/tox: Replace testinfra dependency by pytest-testinfra
Mar 24 2022, 3:36 PM
anlambert committed rDENV0b345639cf52: docker/conf/celery: Disable broker hearbeats (authored by anlambert).
docker/conf/celery: Disable broker hearbeats
Mar 24 2022, 3:36 PM
anlambert closed D7418: docker/env/workers: Set default log level to DEBUG.
Mar 24 2022, 3:36 PM
anlambert committed rDENV164dea75f43f: docker/env/workers: Set default log level to DEBUG (authored by anlambert).
docker/env/workers: Set default log level to DEBUG
Mar 24 2022, 3:36 PM
anlambert requested review of D7422: test_client: Fix failing test since recent swh-model update.
Mar 24 2022, 2:49 PM
anlambert committed rDWAPPS704061c18948: package.json: Upgrade dependencies (authored by anlambert).
package.json: Upgrade dependencies
Mar 24 2022, 1:57 PM
anlambert closed D7396: admin: Add mailmaps administration Web UI.
Mar 24 2022, 1:57 PM
anlambert committed rDWAPPSfe137e22529f: admin: Add mailmaps administration Web UI (authored by anlambert).
admin: Add mailmaps administration Web UI
Mar 24 2022, 1:57 PM
anlambert closed D7416: Add svn_retry decorator to mitigate possible network errors.
Mar 24 2022, 1:28 PM
anlambert committed rDLDSVN6c83c506151e: Add svn_retry decorator to mitigate possible network errors (authored by anlambert).
Add svn_retry decorator to mitigate possible network errors
Mar 24 2022, 1:28 PM
anlambert added a comment to D7418: docker/env/workers: Set default log level to DEBUG.

indeed, that would be fine with me if you can do that

Mar 24 2022, 1:27 PM
anlambert requested review of D7421: docker/conf/celery: Disable broker hearbeats.
Mar 24 2022, 1:26 PM
anlambert updated the diff for D7416: Add svn_retry decorator to mitigate possible network errors.

Update:

  • rename get_remote_access method to remote_access
  • add references to subversion C API functions in docstrings for getting details about parameters
  • fix commit message, max number of attempts is five not three
Mar 24 2022, 11:45 AM
anlambert accepted D7420: Simplify and unify the date field display format in datatable views.
Mar 24 2022, 11:36 AM
anlambert added a comment to D7418: docker/env/workers: Set default log level to DEBUG.

All these are debug logs for SWH apps themselves; and so far they have not been an inconvenience; unlike Celery logs (that's why I wrote D5594)

Most logs should be set to INFO by default, then individually turned to DEBUG when needed.

Mar 24 2022, 10:55 AM
anlambert updated subscribers of D7416: Add svn_retry decorator to mitigate possible network errors.
Mar 24 2022, 10:51 AM
anlambert added a comment to D7418: docker/env/workers: Set default log level to DEBUG.

as they are really useful when working on loaders and listers.

But they are noise when working on other components.

How much logging does this add?

Mar 24 2022, 10:41 AM

Mar 23 2022

anlambert updated the diff for D7416: Add svn_retry decorator to mitigate possible network errors.

Update: Improve debug logging for export and checkout command.

Mar 23 2022, 5:07 PM
anlambert requested review of D7418: docker/env/workers: Set default log level to DEBUG.
Mar 23 2022, 4:57 PM
anlambert updated the diff for D7396: admin: Add mailmaps administration Web UI.

Rebase

Mar 23 2022, 4:30 PM
anlambert requested review of D7416: Add svn_retry decorator to mitigate possible network errors.
Mar 23 2022, 4:29 PM
anlambert closed D7409: cypress: Fix flaky test.
Mar 23 2022, 11:36 AM
anlambert committed rDWAPPS716df4a9d7f7: cypress: Fix flaky test (authored by anlambert).
cypress: Fix flaky test
Mar 23 2022, 11:36 AM
anlambert updated the diff for D7409: cypress: Fix flaky test.

Rebase

Mar 23 2022, 11:04 AM
anlambert added a comment to D7409: cypress: Fix flaky test.

Looks like it worked, will land then.

Mar 23 2022, 11:03 AM
anlambert committed rDCOREba5a6ef533d5: pytest: Exclude build directory for tests discovery (authored by anlambert).
pytest: Exclude build directory for tests discovery
Mar 23 2022, 10:48 AM

Mar 22 2022

anlambert requested review of D7409: cypress: Fix flaky test.
Mar 22 2022, 5:05 PM
anlambert closed D7398: admin/origin_save: Do not modify unauthorized URLs list when rejecting.
Mar 22 2022, 4:43 PM
anlambert committed rDWAPPS74a5fc48c82b: admin/origin_save: Do not modify unauthorized URLs list when rejecting (authored by anlambert).
admin/origin_save: Do not modify unauthorized URLs list when rejecting
Mar 22 2022, 4:43 PM
anlambert updated the diff for D7396: admin: Add mailmaps administration Web UI.

Rebase and add new database migration changing user_id of existing mailmaps in production to None to indicate they have been created by an administrator.

Mar 22 2022, 4:20 PM
anlambert updated the diff for D7398: admin/origin_save: Do not modify unauthorized URLs list when rejecting.

Rebase

Mar 22 2022, 4:17 PM