- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Mar 30 2022
Looks good to me, thanks !
Mar 29 2022
Update:
- Rework new method signature and features (see T4090#82068)
- Address @vlorentz comments
You are still setting a timeout of 30 minutes for all jobs.
Looks good to me.
Mar 28 2022
Add comment in CSS file
I have the feeling that, in terms of API extensibility, we'll want to be returning both the OriginVisit and its latest OriginVisitStatus.
If we don't do that, we might find ourselves in a situation where we want to combine the fields from both objects into one, which feels a bit clunky when we could just return a proper composite type.
In D7441#194120, @vlorentz wrote:I assume that's what is causing the cryptic CI errors?
Fixed and deployed.
Mar 25 2022
Maybe a modal view of the particular request could be done.
Make the row clickable, once clicked, that opens a modal view into
the request details (including comments).
Since we are showing dates in many pages, isn't it better to have a better formatting library?
I am not against it but we should add a redirection for the old URL.
You still need to keep the hashchange event handler or the tabs will not be switched when playing with browser history:
You should put the template in the utils folder instead, no need to create a new bundle for that.
Mar 24 2022
Could you add a cypress test for this ? You can inspire from the one I wrote for save code now.
Remove added line break in test_origin_root_directory_view
Update:
- address @ardumont comment
- update years in license headers
In D7418#193421, @vlorentz wrote:indeed, that would be fine with me if you can do that
Update:
- rename get_remote_access method to remote_access
- add references to subversion C API functions in docstrings for getting details about parameters
- fix commit message, max number of attempts is five not three
In D7418#193403, @vlorentz wrote:All these are debug logs for SWH apps themselves; and so far they have not been an inconvenience; unlike Celery logs (that's why I wrote D5594)
Most logs should be set to INFO by default, then individually turned to DEBUG when needed.
In D7418#193371, @vlorentz wrote:as they are really useful when working on loaders and listers.
But they are noise when working on other components.
How much logging does this add?
Mar 23 2022
Update: Improve debug logging for export and checkout command.
Rebase
Looks like it worked, will land then.
Mar 22 2022
Rebase and add new database migration changing user_id of existing mailmaps in production to None to indicate they have been created by an administrator.
Rebase