Page MenuHomeSoftware Heritage
Differential D7440

Fix handling of initial state of #swh-add-forge-user-filter
ClosedPublic
Actions

Authored by vlorentz on Mar 28 2022, 12:33 PM.

Details

Reviewers
anlambert
Group Reviewers
Reviewers
Commits
rDWAPPSf7281122f2bb: Fix handling of initial state of #swh-add-forge-user-filter

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Mar 28 2022, 12:33 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptMar 28 2022, 12:33 PM
vlorentz mentioned this in D7439: Add Forge Now: Use different views for each tab.Mar 28 2022, 12:33 PM
swh-public-ci added a comment.Mar 28 2022, 12:34 PM

Build has FAILED

Patch application report for D7440 (id=26941)

Could not rebase; Attempt merge onto 6b5aa57b3f...

Updating 6b5aa57b..2057631e
Fast-forward
 assets/src/bundles/add_forge/create-request.js     |  36 +---
 assets/src/bundles/save/index.js                   |  15 +-
 .../add-forge-now-request-create.spec.js           |  17 +-
 cypress/integration/origin-save.spec.js            |   4 +-
 swh/web/add_forge_now/views.py                     |  26 ++-
 swh/web/misc/origin_save.py                        |  20 +-
 .../add_forge_now/create-request-create.html       | 116 ++++++++++++
 .../add_forge_now/create-request-help.html         |  89 +++++++++
 .../add_forge_now/create-request-list.html         |  24 +++
 .../templates/add_forge_now/create-request.html    | 204 +--------------------
 swh/web/templates/layout.html                      |   2 +-
 swh/web/templates/misc/origin-save-help.html       |  54 ++++++
 swh/web/templates/misc/origin-save-list.html       |  27 +++
 swh/web/templates/misc/origin-save.html            |  67 +------
 14 files changed, 386 insertions(+), 315 deletions(-)
 create mode 100644 swh/web/templates/add_forge_now/create-request-create.html
 create mode 100644 swh/web/templates/add_forge_now/create-request-help.html
 create mode 100644 swh/web/templates/add_forge_now/create-request-list.html
 create mode 100644 swh/web/templates/misc/origin-save-help.html
 create mode 100644 swh/web/templates/misc/origin-save-list.html
Changes applied before test
commit 2057631e9f706c42c234a4b2cce384d31a825e65
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Mar 28 12:31:42 2022 +0200

    Fix handling of initial state of #swh-add-forge-user-filter

commit fc7ee23e7639de0884c0307f588b2368e1581b55
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Mar 28 10:56:36 2022 +0200

    Add Forge Now: Use different views for each tab
    
    This is more manageable than handling it manually with URL fragments
    (which repeatedly breaks when adding new tabs).

commit 84c22e278a3437beb06c8969d860c027cfd37f70
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Mar 25 10:46:29 2022 +0100

    Save Code Now: Use different views for each tab
    
    This is IMO more manageable than handling it manually with URL fragments
    (which repeatedly breaks when adding new tabs).
    
    A future commit will do this for Add Forge Now, too.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1599/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1599/console

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 28 2022, 12:35 PM
Harbormaster failed remote builds in B27858: Diff 26941!
vlorentz requested review of this revision.Mar 29 2022, 10:25 AM
vlorentz updated this revision to Diff 26963.Mar 29 2022, 10:27 AM

rebase

ardumont added a subscriber: ardumont.Mar 29 2022, 10:48 AM
ardumont added inline comments.
assets/src/bundles/add_forge/create-request.js
97

Please, drop those debugging instructions when happy.

swh-public-ci added a comment.Mar 29 2022, 10:50 AM

Build was aborted

Patch application report for D7440 (id=26963)

Could not rebase; Attempt merge onto 4bc8aaf1d9...

Updating 4bc8aaf1..ce5608b5
Fast-forward
 assets/src/bundles/add_forge/create-request.js     |  36 +---
 assets/src/bundles/save/index.js                   |  15 +-
 .../add-forge-now-request-create.spec.js           |  17 +-
 cypress/integration/origin-save.spec.js            |   4 +-
 swh/web/add_forge_now/views.py                     |  26 ++-
 swh/web/misc/origin_save.py                        |  20 +-
 .../add_forge_now/create-request-create.html       | 116 ++++++++++++
 .../add_forge_now/create-request-help.html         |  89 +++++++++
 .../add_forge_now/create-request-list.html         |  24 +++
 .../templates/add_forge_now/create-request.html    | 204 +--------------------
 swh/web/templates/layout.html                      |   2 +-
 swh/web/templates/misc/origin-save-help.html       |  54 ++++++
 swh/web/templates/misc/origin-save-list.html       |  27 +++
 swh/web/templates/misc/origin-save.html            |  67 +------
 14 files changed, 386 insertions(+), 315 deletions(-)
 create mode 100644 swh/web/templates/add_forge_now/create-request-create.html
 create mode 100644 swh/web/templates/add_forge_now/create-request-help.html
 create mode 100644 swh/web/templates/add_forge_now/create-request-list.html
 create mode 100644 swh/web/templates/misc/origin-save-help.html
 create mode 100644 swh/web/templates/misc/origin-save-list.html
Changes applied before test
commit ce5608b582eb9d0e278f949f7029fff83d7ef22b
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Mar 28 12:31:42 2022 +0200

    Fix handling of initial state of #swh-add-forge-user-filter

commit b0af8ee47d2926b542908539bf505f73f3b447a6
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Mar 28 10:56:36 2022 +0200

    Add Forge Now: Use different views for each tab
    
    This is more manageable than handling it manually with URL fragments
    (which repeatedly breaks when adding new tabs).

commit 72b5dd24dc3f783c702c47e36fd7a3ecd95b594c
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Mar 25 10:46:29 2022 +0100

    Save Code Now: Use different views for each tab
    
    This is IMO more manageable than handling it manually with URL fragments
    (which repeatedly breaks when adding new tabs).
    
    A future commit will do this for Add Forge Now, too.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1612/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1612/console

Harbormaster failed remote builds in B27879: Diff 26963!Mar 29 2022, 10:50 AM
vlorentz updated this revision to Diff 26970.Mar 29 2022, 10:51 AM

remove debugging code

swh-public-ci added a comment.Mar 29 2022, 11:09 AM

Build is green

Patch application report for D7440 (id=26970)

Could not rebase; Attempt merge onto 4bc8aaf1d9...

Updating 4bc8aaf1..f7281122
Fast-forward
 assets/src/bundles/add_forge/create-request.js     |  34 +---
 assets/src/bundles/save/index.js                   |  15 +-
 .../add-forge-now-request-create.spec.js           |  17 +-
 cypress/integration/origin-save.spec.js            |   4 +-
 swh/web/add_forge_now/views.py                     |  26 ++-
 swh/web/misc/origin_save.py                        |  20 +-
 .../add_forge_now/create-request-create.html       | 116 ++++++++++++
 .../add_forge_now/create-request-help.html         |  89 +++++++++
 .../add_forge_now/create-request-list.html         |  24 +++
 .../templates/add_forge_now/create-request.html    | 204 +--------------------
 swh/web/templates/layout.html                      |   2 +-
 swh/web/templates/misc/origin-save-help.html       |  54 ++++++
 swh/web/templates/misc/origin-save-list.html       |  27 +++
 swh/web/templates/misc/origin-save.html            |  67 +------
 14 files changed, 384 insertions(+), 315 deletions(-)
 create mode 100644 swh/web/templates/add_forge_now/create-request-create.html
 create mode 100644 swh/web/templates/add_forge_now/create-request-help.html
 create mode 100644 swh/web/templates/add_forge_now/create-request-list.html
 create mode 100644 swh/web/templates/misc/origin-save-help.html
 create mode 100644 swh/web/templates/misc/origin-save-list.html
Changes applied before test
commit f7281122f2bb8d88c0cc413d3660db8494c0256f
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Mar 28 12:31:42 2022 +0200

    Fix handling of initial state of #swh-add-forge-user-filter

commit b0af8ee47d2926b542908539bf505f73f3b447a6
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Mar 28 10:56:36 2022 +0200

    Add Forge Now: Use different views for each tab
    
    This is more manageable than handling it manually with URL fragments
    (which repeatedly breaks when adding new tabs).

commit 72b5dd24dc3f783c702c47e36fd7a3ecd95b594c
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Mar 25 10:46:29 2022 +0100

    Save Code Now: Use different views for each tab
    
    This is IMO more manageable than handling it manually with URL fragments
    (which repeatedly breaks when adding new tabs).
    
    A future commit will do this for Add Forge Now, too.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1614/ for more details.

Harbormaster completed remote builds in B27886: Diff 26970.Mar 29 2022, 11:10 AM
anlambert accepted this revision.Mar 29 2022, 11:44 AM
This revision is now accepted and ready to land.Mar 29 2022, 11:44 AM
Closed by commit rDWAPPSf7281122f2bb: Fix handling of initial state of #swh-add-forge-user-filter (authored by vlorentz). · Explain WhyMar 29 2022, 1:14 PM
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDWAPPSf7281122f2bb: Fix handling of initial state of #swh-add-forge-user-filter.

Revision Contents
Changeset List

PathSize
assets/
src/
bundles/
add_forge/
5 lines
cypress/
integration/
4 lines

Diff 26980

View Options

assets/src/bundles/add_forge/create-request.js

Loading...
View Options

cypress/integration/add-forge-now-request-create.spec.js

Loading...
About · Developer information · Legal