Differential D7424

add-forge-now: Fix login link depending on the oidc context
ClosedPublic
Actions

Authored by ardumont on Mar 24 2022, 5:23 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Maniphest Tasks

T4067: [add forge now] - change login link on submit form

Commits

rDWAPPS349c7e5f4e30: add-forge-now: Fix login link depending on the oidc context

Summary

This makes sure we use the right keycloak login link when deployed on staging and
production webapps. This does not change anything for docker and dev makefile targets.

Related to T4067

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Mar 24 2022, 5:23 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 24 2022, 5:23 PM

ardumont edited the summary of this revision. (Show Details)Mar 24 2022, 5:36 PM

ardumont added a task: T4067: [add forge now] - change login link on submit form .

ardumont removed a task: T4075: add forge now - refactor help content.

Build is green

Patch application report for D7424 (id=26872)

Could not rebase; Attempt merge onto 59da42614b...

Updating 59da4261..eb4af3d0
Fast-forward
 .../templates/add_forge_now/create-request.html    | 172 ++++++++++++---------
 1 file changed, 100 insertions(+), 72 deletions(-)

Changes applied before test

commit eb4af3d02105173e28477d7533ce6c89f3083a2d
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Mar 24 17:21:21 2022 +0100

    add-forge-now: Fix login link depending on the oidc context
    
    This makes sure we use the right keycloak login link when deployed on staging and
    production webapps. This does not change anything for docker and dev makefile targets.
    
    Related to T4075

commit 7c86b0e45c389cd63e76a1278570124e9ac32e51
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Mar 24 17:00:40 2022 +0100

    add-forge-now: Refactor help content into a tab
    
    Related to T4075

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1563/ for more details.

Harbormaster completed remote builds in B27785: Diff 26872.Mar 24 2022, 5:42 PM

ardumont requested review of this revision.Mar 24 2022, 5:42 PM

Rebase

Build is green

Patch application report for D7424 (id=26880)

Rebasing onto d5e3f98417...

Current branch diff-target is up to date.

Changes applied before test

commit 349c7e5f4e30f4f4b216c7f1f028fd01a1c4d01b
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Mar 24 17:21:21 2022 +0100

    add-forge-now: Fix login link depending on the oidc context
    
    This makes sure we use the right keycloak login link when deployed on staging and
    production webapps. This does not change anything for docker and dev makefile targets.
    
    Related to T4075

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1569/ for more details.

Harbormaster completed remote builds in B27793: Diff 26880.Mar 25 2022, 9:52 AM

anlambert accepted this revision.Mar 25 2022, 10:45 AM

This revision is now accepted and ready to land.Mar 25 2022, 10:45 AM

Closed by commit rDWAPPS349c7e5f4e30: add-forge-now: Fix login link depending on the oidc context (authored by ardumont). · Explain WhyMar 25 2022, 10:48 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDWAPPS349c7e5f4e30: add-forge-now: Fix login link depending on the oidc context.