Page MenuHomeSoftware Heritage
Differential D7444

assets/webapp.css: Disable common ligatures of Alegreya font
ClosedPublic
Actions

Authored by anlambert on Mar 28 2022, 4:52 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDWAPPS4bc8aaf1d94b: assets/webapp.css: Disable common ligatures of Alegreya font
Summary

The Alegreya font we are using ships some ligatures producing confusing
text rendering, for instance the ligatures for ~ and some characters.

See for instance that bzr origin on staging, the ~ should not be
on top of the u but before it.

So disable common ligatures with CSS.

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Mar 28 2022, 4:52 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptMar 28 2022, 4:52 PM
swh-public-ci added a comment.Mar 28 2022, 5:10 PM

Build has FAILED

Patch application report for D7444 (id=26950)

Rebasing onto ea683ca5ff...

Current branch diff-target is up to date.
Changes applied before test
commit cc8989a3f0def77b67e4f46c6e8e3a8cb3492265
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Mar 28 16:41:08 2022 +0200

    assets/webapp.css: Disable common ligatures of Alegreya font
    
    The Alegreya font we are using ships some ligatures producing confusing
    text rendering, for instance the ligatures for `~` and some characters.
    
    So disable common ligatures with CSS.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1602/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1602/console

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 28 2022, 5:10 PM
Harbormaster failed remote builds in B27866: Diff 26950!
anlambert updated this revision to Diff 26952.Mar 28 2022, 5:17 PM

Rebase

swh-public-ci added a comment.Mar 28 2022, 5:36 PM

Build is green

Patch application report for D7444 (id=26952)

Rebasing onto 117c98447a...

Current branch diff-target is up to date.
Changes applied before test
commit bc7e9d4e80544119fa826733d9058e5b14bc6246
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Mar 28 16:41:08 2022 +0200

    assets/webapp.css: Disable common ligatures of Alegreya font
    
    The Alegreya font we are using ships some ligatures producing confusing
    text rendering, for instance the ligatures for `~` and some characters.
    
    So disable common ligatures with CSS.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1603/ for more details.

Harbormaster completed remote builds in B27868: Diff 26952.Mar 28 2022, 5:36 PM
anlambert requested review of this revision.Mar 28 2022, 5:36 PM
vlorentz added a subscriber: vlorentz.Mar 28 2022, 5:38 PM

Could you add a comment to explain the reason?

anlambert updated this revision to Diff 26954.Mar 28 2022, 5:48 PM

Add comment in CSS file

vlorentz accepted this revision.Mar 28 2022, 5:50 PM

thanks!

This revision is now accepted and ready to land.Mar 28 2022, 5:50 PM
This revision was landed with ongoing or failed builds.Mar 28 2022, 6:04 PM
Closed by commit rDWAPPS4bc8aaf1d94b: assets/webapp.css: Disable common ligatures of Alegreya font (authored by anlambert). · Explain Why
This revision was automatically updated to reflect the committed changes.
anlambert added a commit: rDWAPPS4bc8aaf1d94b: assets/webapp.css: Disable common ligatures of Alegreya font.
ardumont added subscribers: zack, ardumont.Mar 28 2022, 6:06 PM

@zack what you said on the ligature issue (add-forge-now ml thread) ^ it will be fixed soon ;)

swh-public-ci added a comment.Mar 28 2022, 6:06 PM

Build is green

Patch application report for D7444 (id=26954)

Rebasing onto 117c98447a...

Current branch diff-target is up to date.
Changes applied before test
commit 4bc8aaf1d94b6e11b4d5f7e447e5743b4c20b8ab
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Mar 28 16:41:08 2022 +0200

    assets/webapp.css: Disable common ligatures of Alegreya font
    
    The Alegreya font we are using ships some ligatures producing confusing
    text rendering, for instance the ligatures for `~` and some characters.
    
    So disable font common ligatures with CSS.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1604/ for more details.

Harbormaster completed remote builds in B27870: Diff 26954.Mar 28 2022, 6:06 PM

Revision Contents
Changeset List

PathSize
assets/
src/
bundles/
webapp/
9 lines

Diff 26955

View Options

assets/src/bundles/webapp/webapp.css

Loading...
About · Developer information · Legal