I have the feeling that, in terms of API extensibility, we'll want to be returning both the OriginVisit and its latest OriginVisitStatus.

If we don't do that, we might find ourselves in a situation where we want to combine the fields from both objects into one, which feels a bit clunky when we could just return a proper composite type.

So, I would suggest an API of the form:

@attr.s
class OriginVisitWithStatuses:
    visit: OriginVisit
    statuses: List[OriginVisitStatus]

def origin_visit_get_with_latest_status(
    self,
    origin: str,
    allowed_statuses: Optional[List[str]] = None,
    require_snapshot: bool = False, 
    page_token: Optional[str] = None,
    order: ListOrder = ListOrder.ASC,
    limit: int = 10
) -> PagedResult[OriginVisitWithStatuses]

This way, this new API will be getting the extensions to both model objects without needing to change, and we can reuse the combined result type for OV + OVS in other relevant APIs (e.g. ones that would return all statuses instead of a single one).

Alternatively, we could define a one-shot return type such as:

@attr.s
class OriginVisitWithLastStatus:
    visit: OriginVisit
    last_status: Optional[OriginVisitStatus]

Or even drop the Optional, if we make the API return visits only if the latest status exists and matches the filters supplied in the request.

We should probably be deprecating origin_visit_get, while we're here; I don't see a compelling argument for getting origin_visits alone, if we have an API that will easily return them alongside the latest status.

I have the feeling that, in terms of API extensibility, we'll want to be returning both the OriginVisit and its latest OriginVisitStatus.
If we don't do that, we might find ourselves in a situation where we want to combine the fields from both objects into one, which feels a bit clunky when we could just return a proper composite type.

That was my initial idea but in my first implementation returned a PagedResult[Tuple[OriginVisit, OriginVisitStatus]] and tuples could not be serialized by the RPC layer.
I did not think using a composite type, that's a great idea.

So I will update D7442 to add a method with that signature:

@attr.s
class OriginVisitWithStatuses:
    visit: OriginVisit
    statuses: List[OriginVisitStatus]

def origin_visit_get_with_statuses(
    self,
    origin: str,
    allowed_statuses: Optional[List[str]] = None,
    require_snapshot: bool = False, 
    page_token: Optional[str] = None,
    order: ListOrder = ListOrder.ASC,
    limit: int = 10
) -> PagedResult[OriginVisitWithStatuses]

Better returning all statuses as there are only a couple of them for each visit.

We should probably be deprecating origin_visit_get, while we're here; I don't see a compelling argument for getting origin_visits alone, if we have an API that will easily return them alongside the latest status.

Agreed, visit without status info is not really interesting to retrieve.

SGTM, thanks!