Modify default timeouts
ClosedPublic
Actions

Authored by ardumont on Mar 30 2022, 11:35 AM.

Details

Reviewers

olasd
anlambert

Group Reviewers

Reviewers

Commits

rCJSWHaf4a3c0cdc86: Modify default timeouts

Summary

Decrease overall timeouts from 20 to 10 minutes for most modules.

But for:

swh-web: Increase timeout to 25 min. Current 20 minutes is not enough [1]
swh-storage: Keep a slightly larger timeout of 15 min (lots of tests with multiple backend implementations) [3]

(1] Master build history [2] shows almost half of the last master build got aborted (5 out
of 11).

[2] https://jenkins.softwareheritage.org/view/swh%20master/job/DWAPPS/job/tests/

[3] https://jenkins.softwareheritage.org/job/DSTO/job/tests/

Test Plan

tox

Diff Detail

Repository

rCJSWH Jenkins jobs

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont requested review of this revision.Mar 30 2022, 11:35 AM

ardumont created this revision.

Harbormaster completed remote builds in B28005: Diff 27088.Mar 30 2022, 11:35 AM

I think 30 minutes is a lot of time to waste on an actual hang, but it's clear that this set of jobs is already on the edge.

Maybe just bump to 25 minutes first?

(I would also like us to reduce the default timeout for other modules; maybe keep storage at 20 minutes and move other modules back to 10 minutes?)

In D7470#195148, @olasd wrote:

I think 30 minutes is a lot of time to waste on an actual hang, but it's clear that this set of jobs is already on the edge.

Maybe just bump to 25 minutes first?

(I would also like us to reduce the default timeout for other modules; maybe keep storage at 20 minutes and move other modules back to 10 minutes?)

ardumont retitled this revision from swh-web build: Increase timeout to 30 min to Modify default timeouts.Mar 30 2022, 12:08 PM

ardumont edited the summary of this revision. (Show Details)

Adapt according to suggestion

Harbormaster completed remote builds in B28009: Diff 27092.Mar 30 2022, 12:08 PM

Maybe just bump to 25 minutes first?
(I would also like us to reduce the default timeout for other modules; maybe keep storage at 20 minutes and move other modules back to 10 minutes?)

ok

I've adapted according to discussion and kept 20min for storage.
(and d'oh i realized you were already saying keep storage at 20 ¯\_(ツ)_/¯, cool).

Diff description and commit got amended to explain as much.

Checking the last duration column here https://jenkins.softwareheritage.org/view/swh%20master/ I think we're good to go. Thank you!

This revision is now accepted and ready to land.Mar 30 2022, 12:37 PM

anlambert accepted this revision.Mar 30 2022, 1:14 PM

anlambert added inline comments.

jobs/swh-packages.yaml
282	Successful tests run of swh-storage take around 10 minutes to execute so I think we can lower the timeout to 15 minutes when tests hang (due to kafka).
282	See https://jenkins.softwareheritage.org/job/DSTO/ for test durations.