Rebase and address some @vlorentz comments

Rebase

Rebase and address some @vlorentz comments

Looks good to me.

Why not filtering the exception here ?

In D7406#192822, @anlambert wrote:

In D7406#192804, @vlorentz wrote:

I assume you're going to make the same change to every repo? You can use bin/change-all-repos to do that automatically.

Yes I am. I will try to use the script indeed.

In D7406#192804, @vlorentz wrote:

I assume you're going to make the same change to every repo? You can use bin/change-all-repos to do that automatically.

Looks good to me.

Rebase

Update:

• rebase
• fix issues in datatables endpoint implementation
• add missing tests for better coverage

In D7398#192597, @vlorentz wrote:

What made the old code deal with prefixes? From what I can see, it matches on the full URL

Rerebase

Rebase

Rebase and fix some add-forge URLs

Looks good to me.

And you need to sanitize forge URLs before display; currently nothing is stopping me from submitting <script>alert("foo");</script> as forge URL, and it gets interpreted when Datatable inserts it in the DOM. (or as a less malicious example, http://example.org/&amp;=foo is displayed as http://example.org/&=foo

rDWAPPS39bab96e9f0484e04fe837b5162d889b8040980a fixed the issue for save code now but is not deployed yet.

I added another round of comments to handle before landing this. I will accept the diff afterwards.

Cool stuff, thanks !

You miss one of my inline comment to handle tabs switch when playing with browser history.
Add the following event handler to switch tab when URL fragment changed:

$(window).on('hashchange', () => {
  if (window.location.hash === '#browse-requests') {
    $('.nav-tabs a[href="#swh-add-forge-requests-list"]').tab('show');
  } else {
    $('.nav-tabs a[href="#swh-add-forge-submit-request"]').tab('show');
  }
});