Differential D7392

assets/bootstrap: Fix visual feedback of selected form elements
ClosedPublic
Actions

Authored by anlambert on Mar 18 2022, 3:47 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T4060: Selecting buttons and checkboxes gives no visual feedback

Commits

rDWAPPS8e11938147e0: assets/bootstrap: Fix visual feedback of selected form elements

Summary

My bad, a couple of years ago I deactivated box shadows used by
bootstrap to emphasize selected form elements.

Related to T4060

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Mar 18 2022, 3:47 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 18 2022, 3:47 PM

Nice, thanks!

This revision is now accepted and ready to land.Mar 18 2022, 3:48 PM

This revision was landed with ongoing or failed builds.Mar 18 2022, 3:51 PM

Closed by commit rDWAPPS8e11938147e0: assets/bootstrap: Fix visual feedback of selected form elements (authored by anlambert). · Explain Why

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS8e11938147e0: assets/bootstrap: Fix visual feedback of selected form elements.

Build is green

Patch application report for D7392 (id=26700)

Rebasing onto baa6c9a5c5...

Current branch diff-target is up to date.

Changes applied before test

commit 8e11938147e01db9fad6cc5b6c2dd8573fc47abb
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri Mar 18 15:43:26 2022 +0100

    assets/bootstrap: Fix visual feedback of selected form elements
    
    My bad, a couple of years ago I deactivated box shadows used by
    bootstrap to emphasize selected form elements.
    
    Related to T4060

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1503/ for more details.

Harbormaster completed remote builds in B27596: Diff 26700.Mar 18 2022, 4:07 PM