Differential D7393

Activate save code now feature for development related tools
ClosedPublic
Actions

Authored by ardumont on Mar 18 2022, 4:05 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Maniphest Tasks

T4040: [Add forge now] Create a feature flag

Commits

rDWAPPS683b349b01a1: Activate save code now feature for development related tools

Summary

This will avoid having to toggle it on by default all around, see for example [2].

In effect, the configuration will be explicitely toggled appropriately by puppet (off in
production, on on staging) [1]. This will avoid declaring it on in docker tools as well,
so in effect abandoning [2].

That follows a suggestion from @anlambert in [3]

[1] T4040
[2] D7377
[3] D7378#inline-52894

Related to T4040

Test Plan

all tests should still be happy

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Mar 18 2022, 4:05 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 18 2022, 4:05 PM

Build is green

Patch application report for D7393 (id=26716)

Rebasing onto f937632950...

Current branch diff-target is up to date.

Changes applied before test

commit 683b349b01a18fbe48431a6da905433aae9b4083
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Mar 18 16:00:33 2022 +0100

    Activate save code now feature for development related tools
    
    This will avoid having to flip it on by default all around.
    
    Related to T4040

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1507/ for more details.

Harbormaster completed remote builds in B27612: Diff 26716.Mar 18 2022, 4:53 PM

ardumont requested review of this revision.Mar 18 2022, 4:53 PM

anlambert accepted this revision.Mar 18 2022, 4:56 PM

This revision is now accepted and ready to land.Mar 18 2022, 4:56 PM

Closed by commit rDWAPPS683b349b01a1: Activate save code now feature for development related tools (authored by ardumont). · Explain WhyMar 18 2022, 4:57 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDWAPPS683b349b01a1: Activate save code now feature for development related tools.