committer=None happens on some malformed commits generated by old dgit
versions ; and it is possible for author=None to happen for the same reason.
Details
Details
- Reviewers
anlambert douardda olasd - Group Reviewers
Reviewers - Commits
- rDMODdbce3cc6da81: Add support for None as author or committer of a Revision
Diff Detail
Diff Detail
- Repository
- rDMOD Data model
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build is green
Patch application report for D7400 (id=26739)
Rebasing onto bc3831fddc...
Current branch diff-target is up to date.
Changes applied before test
commit 7a70a1646d853987df3ad093043d4544c5eae5cc
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Mon Mar 21 15:41:03 2022 +0100
Add support for None as author or committer of a Revision
committer=None happens on some malformed commits generated by old dgit
versions ; and it is possible for author=None to happen for the same reason.See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/464/ for more details.
Comment Actions
LGTM, thanks
| swh/model/git_objects.py | ||
|---|---|---|
| 339–340 | Eww. (ISTR that at some point I think the subquery for revision_history would come up with an array containing one NULL value...) | |
| swh/model/model.py | ||
|---|---|---|
| 914–915 | I wanted to keep it consistent with date handling. | |
Comment Actions
Build is green
Patch application report for D7400 (id=26813)
Rebasing onto dbce3cc6da...
First, rewinding head to replay your work on top of it... Fast-forwarded diff-target to base-revision-466-D7400.
Changes applied before test
See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/466/ for more details.