Differential D7364

assets/save: Fix Web UI tabs switch when navigating in browser history
ClosedPublic
Actions

Authored by anlambert on Mar 16 2022, 5:29 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDWAPPS39bab96e9f04: assets/save: Fix Web UI tabs switch when navigating in browser history

Summary

In the Save Code Now Web UI, the two displayed tabs have different URLs
but it was not possible to navigate back and forth between them when
clicking on the "Go back" and "Go forward" browser buttons.

So ensure the correct tab will be active when URL fragment has changed.

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Mar 16 2022, 5:29 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 16 2022, 5:29 PM

Build has FAILED

Patch application report for D7364 (id=26620)

Rebasing onto 9f2e1cb90c...

Current branch diff-target is up to date.

Changes applied before test

commit 39bab96e9f0484e04fe837b5162d889b8040980a
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Mar 16 17:24:35 2022 +0100

    assets/save: Fix Web UI tabs switch when navigating in browser history
    
    In the Save Code Now Web UI, the two displayed tabs have different URLs
    but it was not possible to navigate back and forth between them when
    clicking on the "Go back" and "Go forward" browser buttons.
    
    So ensure the correct tab will be active when URL fragment has changed.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1474/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1474/console

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 16 2022, 5:31 PM

Harbormaster failed remote builds in B27503: Diff 26620!

Build is green

Patch application report for D7364 (id=26620)

Rebasing onto 9f2e1cb90c...

Current branch diff-target is up to date.

Changes applied before test

commit 39bab96e9f0484e04fe837b5162d889b8040980a
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Mar 16 17:24:35 2022 +0100

    assets/save: Fix Web UI tabs switch when navigating in browser history
    
    In the Save Code Now Web UI, the two displayed tabs have different URLs
    but it was not possible to navigate back and forth between them when
    clicking on the "Go back" and "Go forward" browser buttons.
    
    So ensure the correct tab will be active when URL fragment has changed.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1475/ for more details.

Harbormaster completed remote builds in B27503: Diff 26620.Mar 16 2022, 5:48 PM

anlambert requested review of this revision.Mar 16 2022, 5:48 PM

ardumont accepted this revision.Mar 16 2022, 5:51 PM

This revision is now accepted and ready to land.Mar 16 2022, 5:51 PM

Closed by commit rDWAPPS39bab96e9f04: assets/save: Fix Web UI tabs switch when navigating in browser history (authored by anlambert). · Explain WhyMar 16 2022, 5:55 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS39bab96e9f04: assets/save: Fix Web UI tabs switch when navigating in browser history.