Page MenuHomeSoftware Heritage

staging: Activate add-forge-now feature
ClosedPublic

Authored by ardumont on Mar 17 2022, 5:56 PM.

Details

Summary

Keep it off in production for now.

Related to T4040
Feature flag introduced in D7370

Test Plan

In webapp staging, we are toggling on the add-forge-now feature:

$SWH_PUPPET_ENVIRONMENT_HOME/bin/octocatalog-diff --octocatalog-diff-args --no-truncate-details --to staging moma
Found host moma.softwareheritage.org
WARN     -> Environment "staging-add-prometheus-metrics" contained non-word characters, correcting name to staging_add_prometheus_metrics
WARN     -> Environment "staging-bullseye-rabbitmq-plugin" contained non-word characters, correcting name to staging_bullseye_rabbitmq_plugin
WARN     -> Environment "staging-check-journal-client" contained non-word characters, correcting name to staging_check_journal_client
WARN     -> Environment "staging-check-journal-client-2nd-implementation" contained non-word characters, correcting name to staging_check_journal_client_2nd_implementation
WARN     -> Environment "staging-check-journal-client-first-implem" contained non-word characters, correcting name to staging_check_journal_client_first_implem
WARN     -> Environment "staging-pin" contained non-word characters, correcting name to staging_pin
Cloning into '/tmp/swh-ocd.gkdyA7N3/environments/production/data/private'...
done.
Cloning into '/tmp/swh-ocd.gkdyA7N3/environments/staging/data/private'...
done.
*** Running octocatalog-diff on host moma.softwareheritage.org
I, [2022-03-18T11:11:52.754180 #176879]  INFO -- : Catalogs compiled for moma.softwareheritage.org
I, [2022-03-18T11:11:53.276062 #176879]  INFO -- : Diffs computed for moma.softwareheritage.org
diff origin/production/moma.softwareheritage.org current/moma.softwareheritage.org
*******************************************
  File[/etc/softwareheritage/web/web.yml] =>
   parameters =>
     content =>
      @@ -91,4 +91,6 @@
         public_key: webapp_give_public_key
         token: webapp_give_token
      +features:
      +  add_forge_now: false
       allowed_hosts:
       - archive.softwareheritage.org
*******************************************
*** End octocatalog-diff on moma.softwareheritage.org
 swh  tony  yavin4  ~  work  …  swh  puppet-environment  swh-site   staging  1⬆  13⚑  ERROR  %  $SWH_PUPPET_ENVIRONMENT_HOME/bin/octocatalog-diff --octocatalog-diff-args --no-truncate-details --to staging webapp.internal.staging.swh.network
Found host webapp.internal.staging.swh.network
WARN     -> Environment "staging-add-prometheus-metrics" contained non-word characters, correcting name to staging_add_prometheus_metrics
WARN     -> Environment "staging-bullseye-rabbitmq-plugin" contained non-word characters, correcting name to staging_bullseye_rabbitmq_plugin
WARN     -> Environment "staging-check-journal-client" contained non-word characters, correcting name to staging_check_journal_client
WARN     -> Environment "staging-check-journal-client-2nd-implementation" contained non-word characters, correcting name to staging_check_journal_client_2nd_implementation
WARN     -> Environment "staging-check-journal-client-first-implem" contained non-word characters, correcting name to staging_check_journal_client_first_implem
WARN     -> Environment "staging-pin" contained non-word characters, correcting name to staging_pin
Cloning into '/tmp/swh-ocd.HQWV0DwM/environments/production/data/private'...
done.
Cloning into '/tmp/swh-ocd.HQWV0DwM/environments/staging/data/private'...
done.
*** Running octocatalog-diff on host webapp.internal.staging.swh.network
I, [2022-03-18T11:12:28.306919 #179372]  INFO -- : Catalogs compiled for webapp.internal.staging.swh.network
I, [2022-03-18T11:12:28.762022 #179372]  INFO -- : Diffs computed for webapp.internal.staging.swh.network
diff origin/production/webapp.internal.staging.swh.network current/webapp.internal.staging.swh.network
*******************************************
  File[/etc/softwareheritage/web/web.yml] =>
   parameters =>
     content =>
      @@ -84,4 +84,6 @@
         public_key: webapp_give_public_key
         token: webapp_give_token
      +features:
      +  add_forge_now: true
       allowed_hosts:
       - webapp.staging.swh.network
*******************************************
*** End octocatalog-diff on webapp.internal.staging.swh.network

Diff Detail

Repository
rSPSITE puppet-swh-site
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.

Adapt according to the other view change

This revision is now accepted and ready to land.Mar 18 2022, 11:07 AM
anlambert added inline comments.
data/common/common.yaml
2251

You should explicitely set add_forge_now to False as django template will read that value.

This revision now requires changes to proceed.Mar 18 2022, 11:09 AM
data/common/common.yaml
2251

True, i missed it after my adaptation.

Adapt according to review (also use yaml true/false instead of python bool values)

This revision is now accepted and ready to land.Mar 18 2022, 11:19 AM