They are user errors, there is nothing we can do about it
and they add clutter to Sentry.
Details
Details
- Reviewers
ardumont anlambert - Group Reviewers
Reviewers - Commits
- rDWAPPSd6605c7a7e91: Do not report BadInputExc to Sentry
Diff Detail
Diff Detail
- Repository
- rDWAPPS Web applications
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build is green
Patch application report for D7407 (id=26759)
Rebasing onto 60666aa2d1...
Current branch diff-target is up to date.
Changes applied before test
commit e18c54d0351ae0f9a266ca08efb307e291e59003
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Tue Mar 22 11:35:42 2022 +0100
Do not report BadInputExc to Sentry
They are user errors, there is nothing we can do about it
and they add clutter to Sentry.See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1526/ for more details.
Comment Actions
lgtm
one suggestion inline.
| swh/web/common/middlewares.py | ||
|---|---|---|
| 57 ↗ | (On Diff #26759) | please, mention here what you said in the description. |
Comment Actions
Build has FAILED
Patch application report for D7407 (id=26767)
Rebasing onto ac5e79103c...
First, rewinding head to replay your work on top of it... Applying: Do not report BadInputExc to Sentry
Changes applied before test
commit 74515a349f4280cd33d9269442e069740bb8e09d
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Tue Mar 22 11:35:42 2022 +0100
Do not report BadInputExc to Sentry
They are user errors, there is nothing we can do about it
and they add clutter to Sentry.Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1530/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1530/console
Comment Actions
Build is green
Patch application report for D7407 (id=26767)
Rebasing onto ac5e79103c...
First, rewinding head to replay your work on top of it... Applying: Do not report BadInputExc to Sentry
Changes applied before test
commit ffcf3aa8dba53c2d1ac11a61e35fe5fa8a774b0a
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Tue Mar 22 11:35:42 2022 +0100
Do not report BadInputExc to Sentry
They are user errors, there is nothing we can do about it
and they add clutter to Sentry.See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1534/ for more details.
Comment Actions
Build has FAILED
Patch application report for D7407 (id=26785)
Rebasing onto d6605c7a7e...
First, rewinding head to replay your work on top of it... Fast-forwarded diff-target to base-revision-1536-D7407.
Changes applied before test
Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1536/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1536/console