Build was aborted

Actions to perform for the migration:

• add the role::swh_kafka_broker role to the new server in puppet and deploy
• stop the staging workers
• stop kafka on journal0
• rsync the content from journal0 to the new server
• update the staging configurations to use the new server as journal
• update the NAT public staging for staging journal on the firewall (https://192.168.50.1/firewall_nat.php)

IMHO This diff should be squashed in D6165 (it's really part of the work adding the rabbitmq-based backend).

@douardda you had a fight with this recently i believe, what antoine is expliciting might interest you

rebase

In T3608#71673, @anlambert wrote:

The issue is, the redirected url (/browse/directory/<sha1>?origin_url=<>) will call the same function (get_snapshot_context) again. This is true for all the urls.
Do you see some other efficient alternative to fix this ticket?

@jayeshv, all costly storage requests result (getting origin visits, snapshot content and size) performed by the get_snapshot_context
function are cached at the django level so no need to worry about performance here as it has already been handled.

LGTM thanks

In D6334#166259, @douardda wrote:

looks ok to me. Just one question, why do you need __future__.annotation?

Update after the correct rebase

Adapt according to suggestion

Use postrotate stanza

Looks good to me apart the warning message that is not correct.

Rebase

Push variables at the top level manifest

Use correct repository

Adapt after discussing with @vsellier

+1, thanks !

Also there is no real value in keeping 3 revisions: the last 2 revisions actually improve/modify the code from the first revision.

this should be squashed with the previous diff, and still my previous question about .gitignore

As others (and I) said, this must come with actual documentation.
As is, I have hard time understanding how this actually works (even after reading the document in hedgdoc).

The issue is, the redirected url (/browse/directory/<sha1>?origin_url=<>) will call the same function (get_snapshot_context) again. This is true for all the urls.
Do you see some other efficient alternative to fix this ticket?

indent...

improve entrypoint script to properly handle a SIGTERM

looks ok to me. Just one question, why do you need __future__.annotation?

One good question got raised on the mailing list thread both by @douardda and @stsp.

*very old comment not pushed for some reason*

neat.

@anlambert might be interested as well ;)

Nice! Fine with the current implem as it's the same as before in a dedicated container so better.

lgtm

Build was aborted

Build was aborted

In T3627#71640, @ardumont wrote:

No, the snippet mentioned filters out refs whose name starts with refs/pulls and finishes with /merge
(i realize i made a typo in the main description..., it's now fixed)

rebase

@zack Maybe the diff ^ will clarify a bit ;)

Build was aborted

According to the snippet referenced by @ardumont, all branch names starting with refs/pull/ should be filtered out.