Page MenuHomeSoftware Heritage

make "yarn install" non-fatal in swh-web entrypoint
Needs RevisionPublic

Authored by stsp on Fri, Oct 1, 10:28 AM.

Details

Reviewers
ardumont
anlambert
Group Reviewers
Reviewers
Summary

This makes it possible to run swh-web in a root-less docker setup.

Diff Detail

Repository
rDENV Development environment
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24137
Build 37666: arc lint + arc unit

Event Timeline

stsp requested review of this revision.Fri, Oct 1, 10:28 AM
ardumont added 1 blocking reviewer(s): Reviewers.
ardumont added subscribers: vlorentz, anlambert, ardumont.

fine to me, @anlambert @vlorentz , thoughts?

Looks good to me apart the warning message that is not correct.

docker/services/swh-web/entrypoint.sh
13

The warning should rather be: WARNING: Could not install or update swh-web frontend dependencies

16

Frontend assets are rebuilt in memory with this call.

This revision now requires changes to proceed.Tue, Oct 5, 11:02 AM
docker/services/swh-web/entrypoint.sh
13

We could also add: You should execute yarn install in your local swh-web folder if you encounter issues related to static assets compilation

@douardda you had a fight with this recently i believe, what antoine is expliciting might interest you