Page MenuHomeSoftware Heritage
Feed Advanced Search

Sep 20 2021

anlambert added a revision to T3256: Propose reason for rejecting a save code now: D6311: admin/origin_save: Parse optional note from rejection POST request body.
Sep 20 2021, 5:48 PM · Save Code Now, Easy hack, Web app
anlambert updated the diff for D6309: common/models: Add note text field to SaveOriginRequest model.

Add missing doc about new note field in apidoc for /origin/save/

Sep 20 2021, 5:43 PM
anlambert committed rDWAPPS670090538797: package.json: Upgrade dependencies (authored by anlambert).
package.json: Upgrade dependencies
Sep 20 2021, 5:08 PM
anlambert committed rDWAPPSe6a022d41ceb: templates/show-swhids: Fix typo in SWHIDs documentation URL (authored by anlambert).
templates/show-swhids: Fix typo in SWHIDs documentation URL
Sep 20 2021, 4:16 PM
anlambert requested review of D6309: common/models: Add note text field to SaveOriginRequest model.
Sep 20 2021, 4:15 PM
anlambert added a revision to T3256: Propose reason for rejecting a save code now: D6309: common/models: Add note text field to SaveOriginRequest model.
Sep 20 2021, 4:00 PM · Save Code Now, Easy hack, Web app

Sep 17 2021

anlambert closed D6301: tarball: Try to guess archive format from mime type as last resort.
Sep 17 2021, 6:14 PM
anlambert committed rDCOREe268896d7652: tarball: Try to guess archive format from mimetype as last resort (authored by anlambert).
tarball: Try to guess archive format from mimetype as last resort
Sep 17 2021, 6:14 PM
anlambert updated the diff for D6301: tarball: Try to guess archive format from mime type as last resort.

Remove debian files added by mistake

Sep 17 2021, 6:11 PM
anlambert updated the diff for D6301: tarball: Try to guess archive format from mime type as last resort.

Fix test when building debian package

Sep 17 2021, 6:09 PM
anlambert updated the diff for D6301: tarball: Try to guess archive format from mime type as last resort.

Update test docstring and remove no longer needed comment

Sep 17 2021, 5:42 PM
anlambert retitled D6301: tarball: Try to guess archive format from mime type as last resort from tarball: Try to guess archive format from mimetype as last resort to tarball: Try to guess archive format from mime type as last resort.
Sep 17 2021, 5:33 PM
anlambert requested review of D6301: tarball: Try to guess archive format from mime type as last resort.
Sep 17 2021, 5:31 PM
anlambert added a revision to T3468: staging: current opam loading issues: D6301: tarball: Try to guess archive format from mime type as last resort.
Sep 17 2021, 5:29 PM · System administration, Opam
anlambert updated the task description for T3468: staging: current opam loading issues.
Sep 17 2021, 5:28 PM · System administration, Opam
anlambert accepted D6292: Ensure that filename fallback out of an url is properly sanitized.

Looks good to me, thanks !

Sep 17 2021, 4:15 PM
anlambert accepted D6287: Allow gitlab lister's name to be overriden by task arguments.
Sep 17 2021, 2:40 PM
anlambert accepted D6286: gitlab: Allow ingestion of hg_git origins as hg ones.
Sep 17 2021, 1:26 PM
anlambert added inline comments to D6286: gitlab: Allow ingestion of hg_git origins as hg ones.
Sep 17 2021, 1:12 PM
anlambert added inline comments to D6286: gitlab: Allow ingestion of hg_git origins as hg ones.
Sep 17 2021, 12:07 PM
anlambert updated the task description for T2489: Git origin without smart transfer protocol support cannot be loaded.
Sep 17 2021, 10:44 AM · Git loader
anlambert accepted D6285: gitlab: Allow listing of instances providing multiple vcs_type.

Looks good to me !

Sep 17 2021, 10:38 AM

Sep 16 2021

anlambert created P1168 (An Untitled Masterwork).
Sep 16 2021, 5:47 PM
anlambert closed D6283: postgresql: Fix get_snapshot_branches return value for empty search.
Sep 16 2021, 3:02 PM
anlambert committed rDSTO9465054ef003: postgresql: Fix get_snapshot_branches return value for empty search (authored by anlambert).
postgresql: Fix get_snapshot_branches return value for empty search
Sep 16 2021, 3:02 PM
anlambert requested review of D6283: postgresql: Fix get_snapshot_branches return value for empty search.
Sep 16 2021, 2:23 PM
anlambert added a revision to T3413: Fix the inconsistency between snapshot_get_branches function in postgresql.storage and cassandra.storage: D6283: postgresql: Fix get_snapshot_branches return value for empty search.
Sep 16 2021, 2:15 PM · Storage manager
anlambert accepted D6278: Update container to install the cvs dependency.
Sep 16 2021, 11:24 AM
anlambert accepted D6275: Adapt extid filtering so it happens server side.

Looks good to me.

Sep 16 2021, 10:54 AM
anlambert closed D6254: package/tests/test_utils: Remove code duplication.
Sep 16 2021, 10:48 AM
anlambert committed rDLDBASEf4fe1f30bbe7: package/tests/test_utils: Remove code duplication (authored by anlambert).
package/tests/test_utils: Remove code duplication
Sep 16 2021, 10:48 AM
anlambert committed rDLDBASE1bd1827fa274: package/utils: Try to extract download filename from response headers (authored by anlambert).
package/utils: Try to extract download filename from response headers
Sep 16 2021, 10:48 AM
anlambert closed D6252: package/utils: Improve downloaded filename extraction.
Sep 16 2021, 10:48 AM
anlambert committed rDLDBASE049c41f6144d: package/utils: Use download response URL to extract filename (authored by anlambert).
package/utils: Use download response URL to extract filename
Sep 16 2021, 10:48 AM
anlambert updated the diff for D6254: package/tests/test_utils: Remove code duplication.

Rebase

Sep 16 2021, 10:43 AM
anlambert updated the diff for D6252: package/utils: Improve downloaded filename extraction.

Rebase

Sep 16 2021, 10:43 AM
anlambert closed D6270: pypi/loader: Filter out sdist archives not of interest.
Sep 16 2021, 10:42 AM
anlambert committed rDLDBASE732999842159: pypi/loader: Filter out sdist archives not of interest (authored by anlambert).
pypi/loader: Filter out sdist archives not of interest
Sep 16 2021, 10:42 AM

Sep 15 2021

anlambert closed D6271: tarball: Add support for uncompressing crate files.
Sep 15 2021, 4:32 PM
anlambert committed rDCORE0ef57a4dd346: tarball: Add support for uncompressing crate files (authored by anlambert).
tarball: Add support for uncompressing crate files
Sep 15 2021, 4:32 PM
anlambert updated the diff for D6271: tarball: Add support for uncompressing crate files.

Simply use of str.endswith

Sep 15 2021, 4:23 PM
anlambert added inline comments to D6271: tarball: Add support for uncompressing crate files.
Sep 15 2021, 4:22 PM
anlambert updated the diff for D6270: pypi/loader: Filter out sdist archives not of interest.

Remove no longer needed call to any

Sep 15 2021, 4:21 PM
anlambert updated the diff for D6270: pypi/loader: Filter out sdist archives not of interest.

Simplify some code

Sep 15 2021, 4:18 PM
anlambert requested review of D6271: tarball: Add support for uncompressing crate files.
Sep 15 2021, 3:56 PM
anlambert requested review of D6270: pypi/loader: Filter out sdist archives not of interest.
Sep 15 2021, 3:42 PM
anlambert added a revision to T3575: Filter out sdist archives that are not of interest: D6270: pypi/loader: Filter out sdist archives not of interest.
Sep 15 2021, 3:39 PM · PyPI loader
anlambert renamed T3575: Filter out sdist archives that are not of interest from Filter out sdist archives that cannot be extracted by swh.core.tarball.uncompress to Filter out sdist archives that are not of interest.
Sep 15 2021, 2:52 PM · PyPI loader
anlambert abandoned D6267: tarball: Add support for uncompressing egg files.

Apparently, decision has been made to not archive egg files so abandoning this.

Sep 15 2021, 2:49 PM
anlambert closed T3576: Add support for Python eggs file processing as Invalid.

Apparently we decided not to archive them so better filtering those files out as proposed in T3575.

Sep 15 2021, 2:47 PM · PyPI loader
anlambert updated the task description for T3576: Add support for Python eggs file processing .
Sep 15 2021, 2:47 PM · PyPI loader
anlambert requested review of D6267: tarball: Add support for uncompressing egg files.
Sep 15 2021, 2:23 PM
anlambert added a revision to T3576: Add support for Python eggs file processing : D6267: tarball: Add support for uncompressing egg files.
Sep 15 2021, 2:22 PM · PyPI loader
anlambert updated the task description for T3576: Add support for Python eggs file processing .
Sep 15 2021, 2:00 PM · PyPI loader
anlambert updated the task description for T3576: Add support for Python eggs file processing .
Sep 15 2021, 2:00 PM · PyPI loader
anlambert triaged T3576: Add support for Python eggs file processing as Normal priority.
Sep 15 2021, 1:58 PM · PyPI loader
anlambert closed D6264: tarball: Try to get archive format before unpacking it.
Sep 15 2021, 1:48 PM
anlambert committed rDCORE632673f6bd1b: tarball: Try to get archive format before unpacking it (authored by anlambert).
tarball: Try to get archive format before unpacking it
Sep 15 2021, 1:48 PM
anlambert updated the diff for D6254: package/tests/test_utils: Remove code duplication.

Rebase

Sep 15 2021, 1:46 PM
anlambert updated the diff for D6252: package/utils: Improve downloaded filename extraction.

Update: Add extracted filename extra sanitization pass.

Sep 15 2021, 1:46 PM
anlambert updated the diff for D6264: tarball: Try to get archive format before unpacking it.

Rebase

Sep 15 2021, 1:42 PM
anlambert closed D6265: tarball: Run unzip in quiet mode.
Sep 15 2021, 1:41 PM
anlambert committed rDCOREe45733e9b47d: tarball: Run unzip in quiet mode (authored by anlambert).
tarball: Run unzip in quiet mode
Sep 15 2021, 1:41 PM
anlambert triaged T3575: Filter out sdist archives that are not of interest as Normal priority.
Sep 15 2021, 1:40 PM · PyPI loader
anlambert requested review of D6265: tarball: Run unzip in quiet mode.
Sep 15 2021, 12:14 PM
anlambert requested review of D6264: tarball: Try to get archive format before unpacking it.
Sep 15 2021, 12:11 PM
anlambert updated the diff for D6254: package/tests/test_utils: Remove code duplication.

Rebase

Sep 15 2021, 11:01 AM

Sep 14 2021

anlambert accepted D6258: Add support for custom SMTP configuration.
Sep 14 2021, 5:33 PM
anlambert accepted D6259: Make swh-vault use mailhog.
Sep 14 2021, 5:32 PM
anlambert accepted D6257: Make mailhog available via nginx.
Sep 14 2021, 5:06 PM
anlambert updated the diff for D6252: package/utils: Improve downloaded filename extraction.
  • Use single regexp and strip quotes and spaces
  • Handle UTF-8 encoding defined in rfc5987
  • Add more test cases
Sep 14 2021, 4:15 PM
anlambert created P1161 (An Untitled Masterwork).
Sep 14 2021, 3:08 PM
anlambert updated the diff for D6254: package/tests/test_utils: Remove code duplication.

Rebase

Sep 14 2021, 2:29 PM
anlambert updated the diff for D6252: package/utils: Improve downloaded filename extraction.

Update: Also handle quoted filename in content-disposition header parsing.

Sep 14 2021, 2:28 PM
anlambert added a comment to D6252: package/utils: Improve downloaded filename extraction.
In D6252#161761, @olasd wrote:

Looks like the format you're expecting for the content-disposition header isn't quite standards-compliant.

https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Disposition says the content-disposition filename entry is supposed to be a quoted string.

Sep 14 2021, 2:14 PM
anlambert requested review of D6254: package/tests/test_utils: Remove code duplication.
Sep 14 2021, 2:03 PM
anlambert requested review of D6252: package/utils: Improve downloaded filename extraction.
Sep 14 2021, 1:58 PM
anlambert closed D6239: package/utils: Add FTP protocol support to download function.
Sep 14 2021, 10:45 AM
anlambert committed rDLDBASEd5e54a5eea1e: package/utils: Add FTP protocol support to download function (authored by anlambert).
package/utils: Add FTP protocol support to download function
Sep 14 2021, 10:45 AM
anlambert updated the diff for D6239: package/utils: Add FTP protocol support to download function.

Rebase

Sep 14 2021, 10:41 AM

Sep 13 2021

anlambert added a project to T3570: Upgrade python3-pkginfo debian package to latest upstream version: System administration.
Sep 13 2021, 5:27 PM · System administration, PyPI loader
anlambert closed D6245: package/pypi: Handle missing Version field in PKG-INFO file.
Sep 13 2021, 4:31 PM
anlambert committed rDLDBASE0efaf7a0ef96: package/pypi: Handle missing Version field in PKG-INFO file (authored by anlambert).
package/pypi: Handle missing Version field in PKG-INFO file
Sep 13 2021, 4:31 PM
anlambert triaged T3570: Upgrade python3-pkginfo debian package to latest upstream version as Normal priority.
Sep 13 2021, 4:29 PM · System administration, PyPI loader
anlambert updated the diff for D6245: package/pypi: Handle missing Version field in PKG-INFO file.

Improve test assertion

Sep 13 2021, 4:13 PM
anlambert requested review of D6245: package/pypi: Handle missing Version field in PKG-INFO file.
Sep 13 2021, 3:24 PM
anlambert closed D6244: package/debian: Handle missing md5sum in source package metadata.
Sep 13 2021, 2:27 PM
anlambert committed rDLDBASE8e00be225c7c: package/debian: Handle missing md5sum in source package metadata (authored by anlambert).
package/debian: Handle missing md5sum in source package metadata
Sep 13 2021, 2:27 PM
anlambert updated the diff for D6244: package/debian: Handle missing md5sum in source package metadata.

Fix typo

Sep 13 2021, 2:18 PM
anlambert added inline comments to D6244: package/debian: Handle missing md5sum in source package metadata.
Sep 13 2021, 2:16 PM
anlambert requested review of D6244: package/debian: Handle missing md5sum in source package metadata.
Sep 13 2021, 2:06 PM
anlambert added a revision to T3547: Debian loader: TypeError: __init__() missing 1 required positional argument: 'md5sum': D6244: package/debian: Handle missing md5sum in source package metadata.
Sep 13 2021, 2:04 PM · Debian loader
anlambert closed T3489: Implement iframe view for content and directory elements, a subtask of T3480: Provide iframe element for the SWH Stories, as Resolved.
Sep 13 2021, 10:50 AM · Acquisition Process (SWHAP), Software Stories, Web app
anlambert closed T3489: Implement iframe view for content and directory elements as Resolved.

This has been implemented and deployed to production, closing this.

Sep 13 2021, 10:50 AM · Software Stories, Web app

Sep 10 2021

anlambert updated the diff for D6239: package/utils: Add FTP protocol support to download function.

Update: explicitely close response once processed

Sep 10 2021, 4:39 PM
anlambert updated the diff for D6239: package/utils: Add FTP protocol support to download function.

Fix test

Sep 10 2021, 4:36 PM
anlambert updated the diff for D6239: package/utils: Add FTP protocol support to download function.

Update: also stream FTP responses.

Sep 10 2021, 4:31 PM
anlambert added inline comments to D6239: package/utils: Add FTP protocol support to download function.
Sep 10 2021, 4:30 PM
anlambert requested review of D6239: package/utils: Add FTP protocol support to download function.
Sep 10 2021, 4:09 PM
anlambert added a revision to T2687: nixguix: Add support for downloads over FTP: D6239: package/utils: Add FTP protocol support to download function.
Sep 10 2021, 4:07 PM · Nixguix loader, Easy hack