postgresql: Fix get_snapshot_branches return value for empty search
9465054ef003
Actions

Description

postgresql: Fix get_snapshot_branches return value for empty search

When searching for branches in an existing snapshot, a PartialBranches
object must be returned regardless the number of found branches.

None should only be returned when a snapshot does not exist.

This fixes an inconsistency between the postgresql and cassandra
backends.

Related to T3413

Details

Provenance

anlambert	Authored on Sep 16 2021, 2:08 PM
anlambert	Pushed on Sep 16 2021, 3:02 PM

Differential Revision

D6283: postgresql: Fix get_snapshot_branches return value for empty search

Parents

rDSTOa9fde72c4816: Allow filtering extids per extid_version/extid_type when reading

Branches

Unknown

Tags

Unknown

Tasks

T3413: Fix the inconsistency between snapshot_get_branches function in postgresql.storage and cassandra.storage

Build Status

Buildable 23685
Build 36972: test-and-build	Jenkins console · Jenkins

Event Timeline

anlambert committed rDSTO9465054ef003: postgresql: Fix get_snapshot_branches return value for empty search (authored by anlambert).Sep 16 2021, 2:09 PM

anlambert added a task: T3413: Fix the inconsistency between snapshot_get_branches function in postgresql.storage and cassandra.storage.Sep 16 2021, 3:02 PM

anlambert added an edge: D6283: postgresql: Fix get_snapshot_branches return value for empty search.

Harbormaster completed building B23685: rDSTO9465054ef003: postgresql: Fix get_snapshot_branches return value for empty search.Sep 16 2021, 3:10 PM

swh-public-ci mentioned this in D6269: cassandra: Make _content_get_from_hashes run concurrently.Sep 16 2021, 3:47 PM

swh-public-ci mentioned this in D6315: postgresql: Fix regression introduced in previous commit.Sep 21 2021, 12:36 PM

Changes (2)

Path

Size

swh/

storage/

postgresql/

storage.py

tests/

storage_tests.py

rDSTO9465054ef003

View Options

swh/storage/postgresql/storage.py