Page MenuHomeSoftware Heritage

Ensure that filename fallback out of an url is properly sanitized
ClosedPublic

Authored by ardumont on Fri, Sep 17, 4:10 PM.

Details

Summary

Otherwise, filename may end up being too long [1]

OSError: [Errno 36] File name too long:

Related to T3468

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D6292 (id=22867)

Rebasing onto f4fe1f30bb...

Current branch diff-target is up to date.
Changes applied before test
commit fabd950d36575aeefd1ec4213c19dc89a4443107
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 17 16:09:07 2021 +0200

    Ensure that filename fallback out of an url is properly sanitized
    
    Otherwise, filename may end up being too long [1]
OSError: [Errno 36] File name too long:
```

Related to T3468
See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/559/ for more details.
anlambert added a subscriber: anlambert.

Looks good to me, thanks !

This revision is now accepted and ready to land.Fri, Sep 17, 4:15 PM