Differential D6244

package/debian: Handle missing md5sum in source package metadata
ClosedPublic
Actions

Authored by anlambert on Sep 13 2021, 2:04 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T3547: Debian loader: TypeError: __init__() missing 1 required positional argument: 'md5sum'

Commits

rDLDBASE8e00be225c7c: package/debian: Handle missing md5sum in source package metadata

Summary

Some debian source package metadata are missing md5 sums for their
files, for instance those from the buster-proposed-updates suite.

So turn the md5sum field from DebianFileMetadata model optional
in order to avoid loading errors.

Related to T3547

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Sep 13 2021, 2:04 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 13 2021, 2:04 PM

Build is green

Patch application report for D6244 (id=22599)

Rebasing onto 50b062adc7...

Current branch diff-target is up to date.

Changes applied before test

commit fd70af2758c107c6cab2f2979676f761b107bd96
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Sep 13 13:59:41 2021 +0200

    package/debian: Handle missing md5sum in source package metadata
    
    Some debian source package metadata are missing md5 sums for their
    files, for instance those from the buster-proposed-updates suite.
    
    So turn the md5sum field from DebianFileMetadata model optional
    in order to avoid loading errors.
    
    Related to T3547

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/540/ for more details.

Harbormaster completed remote builds in B23533: Diff 22599.Sep 13 2021, 2:06 PM

anlambert requested review of this revision.Sep 13 2021, 2:06 PM

Thanks.

One typo inline, nothing blocking.

swh/loader/package/debian/tests/test_debian.py
314–315

This revision is now accepted and ready to land.Sep 13 2021, 2:11 PM

anlambert added inline comments.Sep 13 2021, 2:16 PM

swh/loader/package/debian/tests/test_debian.py
314–315	thanks !

Fix typo

Build is green

Patch application report for D6244 (id=22602)

Rebasing onto 50b062adc7...

Current branch diff-target is up to date.

Changes applied before test

commit 8e00be225c7cf5d7609da1f4fbb85afd44c2314e
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Sep 13 13:59:41 2021 +0200

    package/debian: Handle missing md5sum in source package metadata
    
    Some debian source package metadata are missing md5 sums for their
    files, for instance those from the buster-proposed-updates suite.
    
    So turn the md5sum field from DebianFileMetadata model optional
    in order to avoid loading errors.
    
    Related to T3547

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/541/ for more details.

Harbormaster completed remote builds in B23536: Diff 22602.Sep 13 2021, 2:21 PM

Closed by commit rDLDBASE8e00be225c7c: package/debian: Handle missing md5sum in source package metadata (authored by anlambert). · Explain WhySep 13 2021, 2:27 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDLDBASE8e00be225c7c: package/debian: Handle missing md5sum in source package metadata.