Add alt attribute to logos img.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Sep 2 2021
Fix test
Add missing trailing spaces in django template
Update:
- rebase
- fix guix origins count
Handle @ardumont comments
In D6170#159685, @ardumont wrote:Thanks.
I like how you were able to scrub out the scheduler mocking part as well, nice work!
That had become a mess to maintain so kudos.
In D6170#159680, @vlorentz wrote:Wouldn't a config option be simpler?
In D5992#159578, @ardumont wrote:What do you think ?
yes, good idea. That'd simplify the setup both in docker and prod (as in nothing to do ;)
Sep 1 2021
I think it'd be best to have those tested during packaging.
In D5992#159553, @ardumont wrote:Also I just realized, as it's not completely ready afaik, don't land it yet though.
@anlambert What do you think of this?
Do we want for example to have a configuration (file) option to hide it and we toggle it later, when it's ready?
That'd avoid to let this diff hang.TIA
Aug 31 2021
Update:
- fix test
- remove miscellaneous section and move guix/nixos origins into the regular crawling one
- implement functions to the get the guix/nixos origins count as there is no scheduler metrics for those
In D6004#159479, @zack wrote:quick comment on the "Miscellaneous" category:
- it's not a great name, and it really feels they are "less important" than the others even if we say explicitly they aren't (or maybe because we say so :-))
- and shouldn't the two items in there (nix, guix) go under "regular crawling" anyway? (that would trivially solve the previous point)
the rest LGTM
Update:
- Open search links in new browser tab
- Put coverage widget CSS rules in a dedicated file
The key examples are computer museum websites: they will want to keep the visitor on their website, for visibility reasons, and we need to cater to their needs.
Typically, we should be able to provide them with an embedded view that looks like this (possibly without the "download" and "save again" buttons)
Aug 30 2021
In the future we will also need to answer a more complex use-case where the iframe resembles more as an embedded copy of the archive.
Rebase, improve tuple iteration code and add some docstrings.
where is the Permalinks tab? I do not see it in the images
Rebase
Aug 27 2021
Looks good to me. Such an awesome feature, can't wait to test it in production !
I would go for option 1 but the path breadcrumbs should remain as it enables to ease
the navigation inside the source code tree (especially when an iframe points to a directory).
I propose to put it below the iframe header, it will also be fixed.
s/Mb/MB/
Add comment
Yeah SWHIDs are long so they eat a lot of horizontal space.
The one thing that is missing is the current SWHID I’m viewing.
Maybe use a SWHID (or a badge) instead of the path in the center of the panel… or as a footer like a reference…
Not sure about this, but we need to know what artifact is identified in the iframe.
Aug 26 2021
Some progress report on my work of the last days on the subject.
In D6140#158833, @ardumont wrote:Looks good to me. Could you add a test for this or is it too complicated ? The code is covered but not the introduced behavior,
I'm not entirely sure on how to proceed for the test indeed.
But for sure, it's currently working as expected on the production patched swh-scheduler-journal-client (saatchi).
Looks good to me. Could you add a test for this or is it too complicated ? The code is covered but not the introduced behavior,
Update test according to @ardumont suggesstion
Looks good to me.
Aug 25 2021
Rename count_visit_types to visit_types_count.
- set 3 origins types per row instead of 4 to improve readability
Looks good to me.
I still got an error when packaging swh-search, see below:
(swh) ✔ ~/swh/swh-environment/swh-search [arcpatch-D6131 L|…1⚑ 3] 12:13 $ python3 setup.py sdist bdist_wheel running sdist running egg_info writing swh.search.egg-info/PKG-INFO writing dependency_links to swh.search.egg-info/dependency_links.txt writing entry points to swh.search.egg-info/entry_points.txt writing requirements to swh.search.egg-info/requires.txt writing top-level names to swh.search.egg-info/top_level.txt reading manifest template 'MANIFEST.in' warning: no files found matching 'version.txt' adding license file 'LICENSE' adding license file 'AUTHORS' writing manifest file 'swh.search.egg-info/SOURCES.txt' running check creating swh.search-0.11.3.dev2+g7f5026d creating swh.search-0.11.3.dev2+g7f5026d/docs creating swh.search-0.11.3.dev2+g7f5026d/docs/_static creating swh.search-0.11.3.dev2+g7f5026d/docs/_templates creating swh.search-0.11.3.dev2+g7f5026d/es_config creating swh.search-0.11.3.dev2+g7f5026d/swh creating swh.search-0.11.3.dev2+g7f5026d/swh.search.egg-info creating swh.search-0.11.3.dev2+g7f5026d/swh/search creating swh.search-0.11.3.dev2+g7f5026d/swh/search/api creating swh.search-0.11.3.dev2+g7f5026d/swh/search/query_language creating swh.search-0.11.3.dev2+g7f5026d/swh/search/query_language/test creating swh.search-0.11.3.dev2+g7f5026d/swh/search/query_language/test/corpus creating swh.search-0.11.3.dev2+g7f5026d/swh/search/tests copying files to swh.search-0.11.3.dev2+g7f5026d... copying .gitignore -> swh.search-0.11.3.dev2+g7f5026d copying .pre-commit-config.yaml -> swh.search-0.11.3.dev2+g7f5026d copying AUTHORS -> swh.search-0.11.3.dev2+g7f5026d copying CODE_OF_CONDUCT.md -> swh.search-0.11.3.dev2+g7f5026d copying CONTRIBUTORS -> swh.search-0.11.3.dev2+g7f5026d copying LICENSE -> swh.search-0.11.3.dev2+g7f5026d copying MANIFEST.in -> swh.search-0.11.3.dev2+g7f5026d copying Makefile -> swh.search-0.11.3.dev2+g7f5026d copying Makefile.local -> swh.search-0.11.3.dev2+g7f5026d copying README.md -> swh.search-0.11.3.dev2+g7f5026d copying mypy.ini -> swh.search-0.11.3.dev2+g7f5026d copying package.json -> swh.search-0.11.3.dev2+g7f5026d copying pyproject.toml -> swh.search-0.11.3.dev2+g7f5026d copying pytest.ini -> swh.search-0.11.3.dev2+g7f5026d copying requirements-swh.txt -> swh.search-0.11.3.dev2+g7f5026d copying requirements-test.txt -> swh.search-0.11.3.dev2+g7f5026d copying requirements.txt -> swh.search-0.11.3.dev2+g7f5026d copying setup.cfg -> swh.search-0.11.3.dev2+g7f5026d copying setup.py -> swh.search-0.11.3.dev2+g7f5026d copying tox.ini -> swh.search-0.11.3.dev2+g7f5026d copying yarn.lock -> swh.search-0.11.3.dev2+g7f5026d copying docs/.gitignore -> swh.search-0.11.3.dev2+g7f5026d/docs copying docs/Makefile -> swh.search-0.11.3.dev2+g7f5026d/docs copying docs/cli.rst -> swh.search-0.11.3.dev2+g7f5026d/docs copying docs/conf.py -> swh.search-0.11.3.dev2+g7f5026d/docs copying docs/index.rst -> swh.search-0.11.3.dev2+g7f5026d/docs copying docs/query-language.rst -> swh.search-0.11.3.dev2+g7f5026d/docs copying docs/_static/.placeholder -> swh.search-0.11.3.dev2+g7f5026d/docs/_static copying docs/_templates/.placeholder -> swh.search-0.11.3.dev2+g7f5026d/docs/_templates copying es_config/elasticsearch.keystore -> swh.search-0.11.3.dev2+g7f5026d/es_config copying es_config/elasticsearch.yml -> swh.search-0.11.3.dev2+g7f5026d/es_config copying es_config/jvm.options -> swh.search-0.11.3.dev2+g7f5026d/es_config copying es_config/log4j2.properties -> swh.search-0.11.3.dev2+g7f5026d/es_config copying swh/__init__.py -> swh.search-0.11.3.dev2+g7f5026d/swh copying swh.search.egg-info/PKG-INFO -> swh.search-0.11.3.dev2+g7f5026d/swh.search.egg-info copying swh.search.egg-info/SOURCES.txt -> swh.search-0.11.3.dev2+g7f5026d/swh.search.egg-info copying swh.search.egg-info/dependency_links.txt -> swh.search-0.11.3.dev2+g7f5026d/swh.search.egg-info copying swh.search.egg-info/entry_points.txt -> swh.search-0.11.3.dev2+g7f5026d/swh.search.egg-info copying swh.search.egg-info/not-zip-safe -> swh.search-0.11.3.dev2+g7f5026d/swh.search.egg-info copying swh.search.egg-info/requires.txt -> swh.search-0.11.3.dev2+g7f5026d/swh.search.egg-info copying swh.search.egg-info/top_level.txt -> swh.search-0.11.3.dev2+g7f5026d/swh.search.egg-info copying swh/search/__init__.py -> swh.search-0.11.3.dev2+g7f5026d/swh/search copying swh/search/cli.py -> swh.search-0.11.3.dev2+g7f5026d/swh/search copying swh/search/elasticsearch.py -> swh.search-0.11.3.dev2+g7f5026d/swh/search copying swh/search/in_memory.py -> swh.search-0.11.3.dev2+g7f5026d/swh/search copying swh/search/interface.py -> swh.search-0.11.3.dev2+g7f5026d/swh/search copying swh/search/journal_client.py -> swh.search-0.11.3.dev2+g7f5026d/swh/search copying swh/search/metrics.py -> swh.search-0.11.3.dev2+g7f5026d/swh/search copying swh/search/py.typed -> swh.search-0.11.3.dev2+g7f5026d/swh/search copying swh/search/translator.py -> swh.search-0.11.3.dev2+g7f5026d/swh/search copying swh/search/utils.py -> swh.search-0.11.3.dev2+g7f5026d/swh/search copying swh/search/api/__init__.py -> swh.search-0.11.3.dev2+g7f5026d/swh/search/api copying swh/search/api/client.py -> swh.search-0.11.3.dev2+g7f5026d/swh/search/api copying swh/search/api/server.py -> swh.search-0.11.3.dev2+g7f5026d/swh/search/api copying swh/search/query_language/.gitignore -> swh.search-0.11.3.dev2+g7f5026d/swh/search/query_language copying swh/search/query_language/grammar.js -> swh.search-0.11.3.dev2+g7f5026d/swh/search/query_language copying swh/search/query_language/sample_query -> swh.search-0.11.3.dev2+g7f5026d/swh/search/query_language copying swh/search/query_language/tokens.js -> swh.search-0.11.3.dev2+g7f5026d/swh/search/query_language copying swh/search/query_language/test/corpus/combinations.txt -> swh.search-0.11.3.dev2+g7f5026d/swh/search/query_language/test/corpus copying swh/search/tests/__init__.py -> swh.search-0.11.3.dev2+g7f5026d/swh/search/tests copying swh/search/tests/conftest.py -> swh.search-0.11.3.dev2+g7f5026d/swh/search/tests copying swh/search/tests/test_api_client.py -> swh.search-0.11.3.dev2+g7f5026d/swh/search/tests copying swh/search/tests/test_cli.py -> swh.search-0.11.3.dev2+g7f5026d/swh/search/tests copying swh/search/tests/test_elasticsearch.py -> swh.search-0.11.3.dev2+g7f5026d/swh/search/tests copying swh/search/tests/test_in_memory.py -> swh.search-0.11.3.dev2+g7f5026d/swh/search/tests copying swh/search/tests/test_init.py -> swh.search-0.11.3.dev2+g7f5026d/swh/search/tests copying swh/search/tests/test_journal_client.py -> swh.search-0.11.3.dev2+g7f5026d/swh/search/tests copying swh/search/tests/test_search.py -> swh.search-0.11.3.dev2+g7f5026d/swh/search/tests copying swh/search/tests/test_server.py -> swh.search-0.11.3.dev2+g7f5026d/swh/search/tests copying swh/search/tests/test_translator.py -> swh.search-0.11.3.dev2+g7f5026d/swh/search/tests Writing swh.search-0.11.3.dev2+g7f5026d/setup.cfg running ts_install yarn install v1.22.5 [1/4] Resolving packages... success Already up-to-date. Done in 0.06s. Copying parser files Getting path Generating Creating tar archive removing 'swh.search-0.11.3.dev2+g7f5026d' (and everything under it) running bdist_wheel running build running build_py running ts_build running ts_build_so error: [Errno 2] No such file or directory: 'swh/search/query_language/src/parser.c'
- improve test to check origins logos and search links are present in the rendered HTML page
Aug 24 2021
Fix hypothesis warning
Looks good to me.
Ensure lru caches are cleared before each test.
Great, thanks !
Update tests
Rebase and add test for coverage view.
Fix has been deployed to production, issue is now fixed, closing this.
Aug 23 2021
nice catch.
Aug 20 2021
Rebase
Aug 19 2021
Next step: write tests for that updated view.