Page MenuHomeSoftware Heritage

vault.spec.js: Remove vaultItems from global variables
ClosedPublic

Authored by vlorentz on Aug 24 2021, 11:23 AM.

Details

Summary

So tests don't have side-effects

Diff Detail

Repository
rDWAPPS Web applications
Branch
prepare-vault
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 23112
Build 36046: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 36045: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D6125 (id=22155)

Rebasing onto 8acd726369...

First, rewinding head to replay your work on top of it...
Applying: vault.spec.js: Remove vaultItems from global variables
Changes applied before test
commit cbaea882d109bf8419d71cdb9288cba9f4d6c860
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Aug 24 10:19:22 2021 +0200

    vault.spec.js: Remove vaultItems from global variables
    
    So tests don't have side-effects

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1018/ for more details.

This revision is now accepted and ready to land.Aug 24 2021, 1:49 PM