- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
May 5 2021
rebased
remove dead code and improve a bit the commit message
May 4 2021
besides the type aliasing statements that I find a bit confusing, LGTM.
I'm not very fond of the name of all this (from_disk, HgLoaderFromDisk, etc.) since it makes people think it cannot deal with remote hg repos (which the HgLoaderFromDisk does, but this is not really advertized, as far as I can tell).
Answer (most) vlorentz comments/remark
rebase and improve logging messages
May 3 2021
In D5648#143320, @vlorentz wrote:What's the motivation?
Apr 29 2021
rebase
and MetadataXXX
rebase
and the origin_visit_status_add() specific implementation as well...
I'm not fond of the 'check_missing' name for the argument, but would prefer 'allow_overwrite'.
Apr 28 2021
remove the pprint from the doctest
Apr 27 2021
In D5589#142405, @ardumont wrote:if you are convinced it's a report covering issue, ok then ;)
I would not say all this is crystal clear to me, but overall looks fine.
lgtm
In D5614#142400, @vlorentz wrote:Why only 0o100644 and 0o100755? I don't think we should make the package loaders discard this information just because Git does.
Apr 26 2021
Rebased and updated to current HEAD
rebase
Apr 23 2021
also add lik to the docker page
it works! thx
Apr 22 2021
actually no, it's not the same...
Same as T1957
These revisions are probably coming from https://gitlab.com/gitlab-org/gitlab-test (or a clone)
Ah fun, one of the revisions with this pb, on staging (ba3343bc4fa403a8dfbfcab7fc1a8c29ee34bd69) seems to have been crafted by https://gitlab.com/gitlab-org/gitlab-foss/-/blob/staging-26-fix_add_deploy_key_spec/spec/models/merge_request_diff_commit_spec.rb
Apr 21 2021
Note that none of their parent revisions can be found either in the archive (one invalid revision in a set of ingested revisions prevent any of them being inserted in the database I suppose, but they are already inserted in kafka at this moment).
See T3170 (error generated by the same invalid kafka messages).
Apr 20 2021
So what about exports of the archive available on git-annex?
In T3246#63559, @douardda wrote:do we also intent to have a takedown topic on kafka?
Note that there is the same transient vs cumulative discrepency on the "Accepted requests" graph.
In T1481#63785, @douardda wrote:I think the "submitted requests per visit type / status" graph should be split in 2 parts. Both accepted and rejected are cumulative values that will indefinitely grow, while pending are transient value aiming at staying near zero, so it makes no sense to have them on the same graph.
I think the "submitted requests per visit type / status" graph should be split in 2 parts. Both accepted and rejected are cumulative values that will indefinitely grow, while pending are transient value aiming at staying near zero, so it makes no sense to have them on the same graph.
In T3084#63569, @douardda wrote:is there a grafana dashboard dedicated to this queue?
Apr 19 2021
In D5553#140866, @anlambert wrote:Looks good to me. It's true the black version we are using is quite outdated.
We should upgrade black in all other swh repositories in the same manner then.