but OriginVisit (which requires _add() method normalization).
Also remove unused 'FilteringProxyStorage.object_types' class attribute.
Diff Detail
Diff Detail
- Repository
- rDSTO Storage manager
- Branch
- tenacious
- Lint
Lint Skipped - Unit
Unit Tests Skipped - Build Status
Buildable 21155 Build 32832: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 32831: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D5646 (id=20159)
Rebasing onto 92d551a4a5...
Current branch diff-target is up to date.
Changes applied before test
commit 75fd304bb204274b027c4b9bee98f33cf38ad910
Author: David Douard <david.douard@sdfa3.org>
Date: Thu Apr 29 15:25:08 2021 +0200
Make buffer and validate proxy storage also handle other object types
but OriginVisit (which requires _add() method normalization).
Also remove unused 'FilteringProxyStorage.object_types' class attribute.See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1289/ for more details.
Comment Actions
Build is green
Patch application report for D5646 (id=20161)
Rebasing onto 92d551a4a5...
Current branch diff-target is up to date.
Changes applied before test
commit 1d575fc8ebeef8ee38e819af6aa1909e93fce76d
Author: David Douard <david.douard@sdfa3.org>
Date: Thu Apr 29 15:25:08 2021 +0200
Make buffer and validate proxy storage also handle other object types
but OriginVisit (which requires _add() method normalization).
Also remove unused 'FilteringProxyStorage.object_types' class attribute.See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1290/ for more details.
Comment Actions
Build is green
Patch application report for D5646 (id=20162)
Rebasing onto 92d551a4a5...
Current branch diff-target is up to date.
Changes applied before test
commit c8e5bcdf9b8c5575cd4779e759a69b001cfe1c85
Author: David Douard <david.douard@sdfa3.org>
Date: Thu Apr 29 15:25:08 2021 +0200
Make buffer and validate proxy storage also handle other object types
but OriginVisit (which requires _add() method normalization).
Also remove unused 'FilteringProxyStorage.object_types' class attribute.See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1291/ for more details.
Comment Actions
Build was aborted
Patch application report for D5646 (id=20164)
Rebasing onto 92d551a4a5...
Current branch diff-target is up to date.
Changes applied before test
commit 280386107925c29404c4a8caec48d222ebfb0d01
Author: David Douard <david.douard@sdfa3.org>
Date: Thu Apr 29 15:25:08 2021 +0200
Make buffer and validate proxy storage also handle other object types
but OriginVisit (which requires _add() method normalization).
Also remove unused 'FilteringProxyStorage.object_types' class attribute.Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1293/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1293/console
Comment Actions
Build is green
Patch application report for D5646 (id=20166)
Rebasing onto 92d551a4a5...
Current branch diff-target is up to date.
Changes applied before test
commit 0161570ec16117df782cded80f6a3704e9aaa39f
Author: David Douard <david.douard@sdfa3.org>
Date: Thu Apr 29 15:25:08 2021 +0200
Make buffer and validate proxy storage also handle other object types
but OriginVisit (which requires _add() method normalization).
Also remove unused 'FilteringProxyStorage.object_types' class attribute.See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1295/ for more details.
| swh/storage/buffer.py | ||
|---|---|---|
| 64 | hmm, they can be pretty big. You may want to divide this by 10 | |
| swh/storage/buffer.py | ||
|---|---|---|
| 64 | I wasn't sure, so ok | |
Comment Actions
The buffer bits look reasonable to me. I'm not so sure about the validator bits, as we're not actually storing the id fields for these objects, afaik?