Page MenuHomeSoftware Heritage

Fix storage_data hardcoded id values
ClosedPublic

Authored by douardda on Fri, Apr 23, 3:52 PM.

Details

Summary

and add a test to check this stays accurate, so that these objects can
pass throught the validate proxy storage, for example.

Note: we could just remove these hardcoded ids from storage_data.py, but I think it's best to keep them: it makes it easier to debug failed tests etc. IMHO

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build was aborted

Patch application report for D5587 (id=19974)

Rebasing onto eb8c147a54...

Current branch diff-target is up to date.
Changes applied before test
commit 2c477ec442b7feb14b5c9f51733afdc78891aa6d
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Apr 23 15:38:14 2021 +0200

    Fix storage_data hardcoded id values
    
    and add a test to check this stays accurate, so that these objects can
    pass throught the validate proxy storage, for example.

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1269/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1269/console

Harbormaster returned this revision to the author for changes because remote builds failed.Fri, Apr 23, 4:13 PM
Harbormaster failed remote builds in B20976: Diff 19974!

Build is green

Patch application report for D5587 (id=19974)

Rebasing onto eb8c147a54...

Current branch diff-target is up to date.
Changes applied before test
commit 2c477ec442b7feb14b5c9f51733afdc78891aa6d
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Apr 23 15:38:14 2021 +0200

    Fix storage_data hardcoded id values
    
    and add a test to check this stays accurate, so that these objects can
    pass throught the validate proxy storage, for example.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1270/ for more details.

This revision is now accepted and ready to land.Mon, Apr 26, 3:08 PM
This revision was automatically updated to reflect the committed changes.