fix the fix

small fix

• Add a content replayer service
• cli: extract the JournalClient instanciation in a dedicated function
• replay: make unexpectedly received object_type log a warning

ok ok, I did split the kafka mock class in 2

add a TODO in test_cli about content-replay

replay: log warnings in case of unexpected object types

In D1541#34664, @vlorentz wrote:

Also, your new CLI needs tests :)

fix an error (brokers can be a tuple) making test_cli fails

The diffs looks fine, but I'd like to have confirmation the code works properly in real conditions (in a docker session) before we merge this.

fix commit msg

should address vlortenz's comments

Several refactorings and git history cleanups

this is now part of D1540

rebase + fix typo

After discussion with my fellow colleagues, we are going to use a debian-packages-based installation but inside dockers to keep the install procedure as close to our production setup as possible without too much hassle.

For the record, we do have a docker based deployment for this, but not a 'production' (aka based on debian packages) one. So I close this task for now. The task is now to document this (T1782).

In D1492#33863, @nahimilega wrote:

Let's just agree to disgree here. Some of us know how to do this with packages, and have done for years if not decades.

@eddelbuettel I didn't had an opportunity to work on a project with two languages and combine them, it is my first time. I would love to learn the way it is done and made ready for production.

In D1501#33584, @vlorentz wrote:

• Make JournalClient take a worker function, instead of using inheritence.

I may have made stupid comments, but...

In D1492#33485, @nahimilega wrote:

@douardda Thanks for helping me out to improve commit messages.
Although I was wondering before landing the diff we usually squash all the commits to one single one, so what is the need to follow strict guidelines for commit messages in the process of improving the diff. I mean at the end they all are going to be squashed to one single commit. :)

I am not very happy with the API of the JournalClient (it's not the result of this diff, but since we are discussing refactorings in there...)

Add a 'lister' click.group for consistency reasons

rebased

Also, please use the imperative form also for your commit messages.

Sorry to insist: commit messages are better, but still lacks at least the imperative form. Also do keep in mind the why-not-how when writing the body of the commit message.
Thanks.

use CONTEXT_SETTINGS from core + several improvements

add dependency on swh.core and import CONTEXT_SETTINGS from there

Please write your commit messages according to the coding guidelines https://chris.beams.io/posts/git-commit/ as described on the wiki

add a comment in the tox.ini file

rebased and typos in the README file.

more help msg tweaking

Better help message using metavars

The help msg stuff in cli provides:

$ swh vault rpc-serve -h
Usage: swh vault rpc-serve [OPTIONS]

pushed one spurious revision, sorry