Page MenuHomeSoftware Heritage

lister: Unify credentials configuration structure between listers
ClosedPublic

Authored by ardumont on May 29 2019, 12:14 PM.

Details

Summary

This becomes a dictionary of key <lister-name>, value a dict of key
<instance-name>, value list of dict username/password.

This allows configuration change to allow the following:

credentials:
  github:  # github lister
    github:  # has only one instance (so far)
    - username: some
      password: somekey
    - username: one
      password: onekey
    - ...
  gitlab:  # gitlab lister
    riseup:  # has many instances
    - username: someone
      password: ...
    - ...
    gitlab:
    - username: someone
      password: ...
    - ...

Related T1772

Test Plan

tox

Diff Detail

Repository
rDLS Listers
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.May 29 2019, 12:14 PM
ardumont planned changes to this revision.May 29 2019, 12:22 PM
ardumont edited the summary of this revision. (Show Details)May 29 2019, 12:28 PM
ardumont edited the test plan for this revision. (Show Details)
ardumont added a reviewer: douardda.
ardumont updated this revision to Diff 5004.May 29 2019, 12:34 PM

Improve docstrings and fix wrong data introspection

ardumont planned changes to this revision.May 29 2019, 12:35 PM
ardumont updated this revision to Diff 5005.May 29 2019, 1:28 PM

Add missing phabricator lister instance

ardumont retitled this revision from lister: Unify credentials structure between listers to lister: Unify credentials configuration structure between listers.May 29 2019, 1:38 PM
ardumont updated this revision to Diff 5006.May 29 2019, 1:40 PM

Fix missing phabricator unit tests update

douardda accepted this revision.May 29 2019, 1:51 PM
This revision is now accepted and ready to land.May 29 2019, 1:51 PM
ardumont updated this revision to Diff 5007.May 29 2019, 2:00 PM

Update docstrings
Add instance fallback behavior to parsing the forge url if instance not provided

This revision was automatically updated to reflect the committed changes.