rebased

include forgotten patch: add log_level to 'swh' context obj

In D1427#31806, @douardda wrote:

In D1427#31768, @vlorentz wrote:

Shouldn't we add tests to make sure that core features work without the extras?

yeah that's something I had in mind, but not sure how to test it without depending on venvs/tox ("raw" pytest)...

In D1427#31768, @vlorentz wrote:

Shouldn't we add tests to make sure that core features work without the extras?

rebased

Use proper swh.cli.subcommands entrypoint

rebase

Implement the entrypoint loading mechanism using functions instead of modules

we (@anlambert and I) will try to have this task closed ASAP (like today, if no big bad stopper arise in front of us)

no need to keep the cli plugins in a dict

rebased

Add requests to requirements.txt since it does come with swh.core any more

kill the PostresHandler instead of "shuffling it around" (© olasd)

In D1427#31359, @olasd wrote:

The PostgresHandler has been dead code for two years, I think we can just remove it rather than shuffling it around.

Fix commit messages

This also requires we can install only a very light base version of swh.core (typically without db or aiohttp/flask dependencies).

A possible way of doing such a thing is to have a master swh command declared in this package as the main entry point: the swh command group (using click) which defines a few very command command line options (like --log-level), and a mechanism to load installed SWH cli plugins via setuptools' pkg_resources

This generic swh cli should be done so that is minimal dependency installed especially for "pure client" commands (e.g. swh.deposit's deposit or swh.model's identify tools).

Currently, we have:

It is these graphs we are still missing.

Indeed it is the object of T1428. That's why I am a bit puzzled the work you have in progress does not simply target T1356. I was expecting some response to this very task in your grafanalib based code, which I did not find. So I was wondering if I missed something, that some data where still in munin only.

In T1442#30575, @ftigeot wrote:

When I asked where to put such work-in-progress, you suggested the snippets repository.

LGTM

In T1442#30564, @ftigeot wrote:

Work-in-progress Grafanalib dashboards have been added to the https://forge.softwareheritage.org/source/snippets/ repository.

As discussed earlier, this task should be actually the first step of a more generic software-heritage cli client module (using HTTP based AIPs/RPCs).

LGTM but I'm not very familiar with this code.

could you explain in the commit message why this solves a cnx leak?

few minor fixes to be make, then should be ok.

lgtm (but I'm obviously biased)

lgtm

In D1404#30533, @vlorentz wrote:

That code (and the lines before) look very similar to each other.

ok but see my comment plz