Paths

Table of Contentst

Differential D1346

docker-compose: Add journal-backfiller
ClosedPublic
Actions

Authored by ardumont on Apr 4 2019, 4:18 PM.

Tags

None

Subscribers

Details

Reviewers

olasd
douardda
vlorentz
anlambert

Group Reviewers

Commits

rDENV848401f512e6: README: Update to demonstrate how to run the backfiller
rDENV0bcb82bcd457: docker-compose: Add journal-backfiller
rDENVc04db2b6cf7f: Ignore override docker-compose file
rCDFD0bcb82bcd457: docker-compose: Add journal-backfiller
rCDFD848401f512e6: README: Update to demonstrate how to run the backfiller
rCDFDc04db2b6cf7f: Ignore override docker-compose file

Summary

Depends on D1345

Diff Detail

Repository

rCDFD Dockerfiles for developers

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Apr 4 2019, 4:18 PM

Harbormaster completed remote builds in B5104: Diff 4302.Apr 4 2019, 4:18 PM

ardumont mentioned this in D1345: swh.journal: Add backfiller implementation.Apr 4 2019, 4:18 PM

Looks good to me!

This revision is now accepted and ready to land.Apr 4 2019, 8:05 PM

I'm not very fond adding this kind of service in the main docker-compose file.
I would prefer a dedicated docker-compose file to be used as an override, eg:

docker-compose -f docker-compose.yml -f docker-compose.backfiller.yml up

(with proper doc in the README).

This revision now requires changes to proceed.Apr 5 2019, 4:51 PM

I'm not very fond adding this kind of service in the main docker-compose file.
I would prefer a dedicated docker-compose file to be used as an override, eg:
docker-compose -f docker-compose.yml -f docker-compose.backfiller.yml up
(with proper doc in the README).

Sure!
It was to give access on how to test the D1345 at the time (not necessarily to merge it as is).

ardumont planned changes to this revision.Apr 8 2019, 2:52 PM

Rebase and plug diff to a branch

Harbormaster completed remote builds in B5220: Diff 4413.Apr 9 2019, 1:06 PM

ardumont planned changes to this revision.Apr 9 2019, 1:06 PM

Ignore override docker-compose file
docker-compose: Add journal-backfiller
README: Update to demonstrate how to run the backfiller

Harbormaster completed remote builds in B5429: Diff 4567.Apr 13 2019, 4:16 PM

few minor fixes to be make, then should be ok.

README.md
669 ↗	(On Diff #4567)	please use the plain `docker-compose` command here
conf/journal_backfiller.yml
9 ↗	(On Diff #4567)	Not to be fixed now, but this should be handled the generic way: have a `storage` section to configure the storage to use (which should then be instantiated by the standard storage factory function `swh.storage.get_storage`).
services/swh-journal-backfiller/entrypoint.sh
7 ↗	(On Diff #4567)	unless I'm mistaken, this is already done in the setup_pip command.

This revision now requires changes to proceed.Apr 15 2019, 12:44 PM

ardumont marked 2 inline comments as done.Apr 15 2019, 2:26 PM

ardumont added inline comments.

services/swh-journal-backfiller/entrypoint.sh
7 ↗	(On Diff #4567)	Indeed

Adapt according to review

Harbormaster completed remote builds in B5440: Diff 4579.Apr 15 2019, 2:27 PM

douardda accepted this revision.Apr 15 2019, 4:42 PM

This revision is now accepted and ready to land.Apr 15 2019, 4:42 PM

Rebase on master

Harbormaster completed remote builds in B5445: Diff 4582.Apr 15 2019, 5:33 PM

Closed by commit rCDFDc04db2b6cf7f: Ignore override docker-compose file (authored by ardumont). · Explain WhyApr 15 2019, 5:33 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDENVc04db2b6cf7f: Ignore override docker-compose file.Nov 26 2019, 1:35 PM

ardumont added a commit: rDENV0bcb82bcd457: docker-compose: Add journal-backfiller.

ardumont added a commit: rDENV848401f512e6: README: Update to demonstrate how to run the backfiller.

Revision Contents
Changeset List

Path

Size

3 lines

Diff 4583

.gitignore

Loading...