Page MenuHomeSoftware Heritage

tasks: fix handling of unsupported promise.save() calls
ClosedPublic

Authored by douardda on Apr 11 2019, 11:06 AM.

Details

Summary

the exception can also be an AttributeError.

Also do not reraise this exception (in github/tasks.py). This promise
saving feature is used for tests.

Diff Detail

Repository
rDLS Listers
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Apr 11 2019, 11:06 AM
vlorentz accepted this revision.Apr 11 2019, 11:10 AM
vlorentz added a subscriber: vlorentz.

That code (and the lines before) look very similar to each other.

This revision is now accepted and ready to land.Apr 11 2019, 11:10 AM

That code (and the lines before) look very similar to each other.

indeed! more refactoring in sight!

This revision was automatically updated to reflect the committed changes.