Page MenuHomeSoftware Heritage
Differential D1428

cli: make the deposit cli command a subcommand of the main 'swh' one
ClosedPublic
Actions

Authored by douardda on Apr 19 2019, 2:38 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDDEPc0b1d5467669: cli: make the deposit cli command a subcommand of the main 'swh' one
rDDEPf5624c801b68: cli: rename the 'deposit' subcommand as 'upload'
rDDEPbf2fb8692bc0: cli: rename cli/deposit.py as cli/client.py to prevent a name clash
Summary

'swh' being the new master command group (defined in swh.core); so:

swh deposit --help

works. The 'admin' (deposit server management) is only available if the
swh.deposit[server] optional package is installed.

Ensure the 'swh-deposit' still works for now.

also rename the 'deposit' subcommand as 'upload'
to prevent the ugly 'swh deposit deposit' in favor of:

swh deposit upload

Depends on D1426.
Related to T1671.

Diff Detail

Repository
rDDEP Push deposit
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Apr 19 2019, 2:38 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptApr 19 2019, 2:38 PM
douardda edited the summary of this revision. (Show Details)Apr 19 2019, 2:39 PM
douardda edited the summary of this revision. (Show Details)
swh-public-ci added a comment.Apr 19 2019, 2:42 PM

Build is green
See https://jenkins.softwareheritage.org/job/DDEP/job/tox/127/ for more details.

Harbormaster completed remote builds in B5515: Diff 4636.Apr 19 2019, 2:42 PM
douardda added a child revision: D1429: docs: update the getting-started document to use 'swh deposit upload' command.Apr 19 2019, 3:27 PM
douardda updated this revision to Diff 4642.Apr 19 2019, 3:50 PM

Add requests to requirements.txt since it does come with swh.core any more

swh-public-ci added a comment.Apr 19 2019, 3:53 PM

Build is green
See https://jenkins.softwareheritage.org/job/DDEP/job/tox/130/ for more details.

Harbormaster completed remote builds in B5521: Diff 4642.Apr 19 2019, 3:53 PM
ardumont added a subscriber: ardumont.May 6 2019, 11:56 AM
ardumont added inline comments.
setup.py
59 ↗(On Diff #4642)

Isn't it supposed to be swh.cli.subcommands?

douardda updated this revision to Diff 4693.May 6 2019, 1:39 PM

Use proper swh.cli.subcommands entrypoint

swh-public-ci added a comment.May 6 2019, 1:42 PM

Build is green
See https://jenkins.softwareheritage.org/job/DDEP/job/tox/132/ for more details.

Harbormaster completed remote builds in B5577: Diff 4693.May 6 2019, 1:42 PM
ardumont accepted this revision.May 6 2019, 1:46 PM
This revision is now accepted and ready to land.May 6 2019, 1:46 PM
douardda updated this revision to Diff 4703.May 6 2019, 3:31 PM

depends on swh.core 0.0.60

swh-public-ci added a comment.May 6 2019, 3:32 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tox/134/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tox/134/console

Harbormaster failed remote builds in B5589: Diff 4703!May 6 2019, 3:32 PM
This revision was landed with ongoing or failed builds.May 6 2019, 3:34 PM
Closed by commit rDDEPbf2fb8692bc0: cli: rename cli/deposit.py as cli/client.py to prevent a name clash (authored by douardda). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
swh/
deposit/
cli/
2 lines
4 lines
client.py
deposit.py

Diff 4706

View Options

swh/deposit/cli/__init__.py

Loading...
View Options

swh/deposit/cli/admin.py

Loading...
View Options

swh/deposit/cli/client.py

Loading...
View Options

swh/deposit/cli/deposit.py

Loading...
About · Developer information · Legal