Page MenuHomeSoftware Heritage
Differential D1417

Fix connection leaks in revision_add and directory_add.
ClosedPublic
Actions

Authored by vlorentz on Apr 15 2019, 12:43 PM.

Details

Reviewers
douardda
ardumont
Group Reviewers
Reviewers
Commits
rDSTOC685b60180e4c: Make revision_add and directory_add call `_missing` using the same transaction.
rDSTO685b60180e4c: Make revision_add and directory_add call `_missing` using the same transaction.

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Apr 15 2019, 12:43 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptApr 15 2019, 12:43 PM
swh-public-ci added a comment.Apr 15 2019, 12:48 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/370/ for more details.

Harbormaster completed remote builds in B5437: Diff 4575.Apr 15 2019, 12:48 PM
douardda added a subscriber: douardda.Apr 15 2019, 1:27 PM

could you explain in the commit message why this solves a cnx leak?

douardda requested changes to this revision.Apr 15 2019, 1:27 PM
This revision now requires changes to proceed.Apr 15 2019, 1:27 PM
vlorentz updated this revision to Diff 4576.Apr 15 2019, 1:58 PM

Better commit message.

swh-public-ci added a comment.Apr 15 2019, 2:03 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/371/ for more details.

Harbormaster completed remote builds in B5438: Diff 4576.Apr 15 2019, 2:03 PM
vlorentz updated this revision to Diff 4578.Apr 15 2019, 2:22 PM

Fix commit message to match the actual source of the error.

swh-public-ci added a comment.Apr 15 2019, 2:28 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/372/ for more details.

Harbormaster completed remote builds in B5439: Diff 4578.Apr 15 2019, 2:28 PM
ardumont accepted this revision.Apr 15 2019, 2:30 PM
douardda accepted this revision.Apr 15 2019, 4:39 PM
This revision is now accepted and ready to land.Apr 15 2019, 4:39 PM
vlorentz updated this revision to Diff 4588.Apr 16 2019, 10:27 AM

rebase

This revision was landed with ongoing or failed builds.Apr 16 2019, 10:27 AM
Closed by commit rDSTO685b60180e4c: Make revision_add and directory_add call `_missing` using the same transaction. (authored by vlorentz). · Explain Why
This revision was automatically updated to reflect the committed changes.
Harbormaster failed remote builds in B5451: Diff 4588!Apr 16 2019, 10:27 AM
swh-public-ci added a comment.Apr 16 2019, 10:27 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/373/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/373/console

Revision Contents
Changeset List

PathSize
swh/
storage/
5 lines

Diff 4589

View Options

swh/storage/storage.py

Loading...
About · Developer information · Legal