This diff is mainly here for discussion on how to implement such a thing
and what kind of 'plugin system' could be provided, especially for features
like lister, loaders and more generally scheduler-managed workers.
Depends on D1503.
Differential D1504
implement listers as plugins douardda on May 22 2019, 2:49 PM. Authored by
Details
This diff is mainly here for discussion on how to implement such a thing Depends on D1503.
Diff Detail
Event TimelineComment Actions Build has FAILED Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tox/136/ Comment Actions Would it be possible to deduplicate the register code by putting all these functions in a single file directly in swh/lister/?
Comment Actions rebase + changes in the plugin "API" now the register function is expected to return a dict with:
If 'init' is not present, default implementation creates tables corresponding Comment Actions Build has FAILED Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tox/308/ Comment Actions Build has FAILED Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tox/320/ Comment Actions Build has FAILED Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tox/333/ Comment Actions This sounds good. It untangles some part like the npm initialization (multiple tables to init). And makes it more declarative, /me likes. The ci is unhappy though. I'm not sure why... oh might be because of the needed changes in the scheduler part... (the diff this diff depends on or something). Comment Actions rebase + better ci msg + improve config handling in cli.py
+ add the --config-file option at the swh lister (group) level (also move
Comment Actions Build has FAILED Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tox/336/ Comment Actions Build is green |