Page MenuHomeSoftware Heritage

Several fixes in npm, cgit and phab listers
ClosedPublic

Authored by douardda on Tue, Sep 3, 12:03 PM.

Details

Summary

This diff consists in 3 commits:

  • cgit: fix cgit's task module and tests forgot some url_prefix there.
  • phabricator: fix the FullPhabricatorLister task

    forgot the forge_url -> api_baseurl renaming in there.
  • npm: make NpmVisitModel use the main declarative base class from core.models

    This is needed by the (refactored) db init mechanism, since this later uses the main declarative base class (thus the main MetaData instance) to gather tables to be created/dropped.

Diff Detail

Repository
rDLS Listers
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Tue, Sep 3, 12:03 PM
ardumont accepted this revision.Tue, Sep 3, 1:13 PM
ardumont added a subscriber: ardumont.

ok with those fixes.

The ci is still red with errors in the swh.lister.cli.get_lister method (relative to the constructor refactoring as well).
My guess is that's not an issue since it will get deprecated by the plugin refactoring.

This revision is now accepted and ready to land.Tue, Sep 3, 1:13 PM
douardda updated this revision to Diff 6529.Tue, Sep 3, 3:04 PM

Fix cli.py for test_cli to pass (phabricator)

ardumont accepted this revision.Tue, Sep 3, 3:10 PM
This revision was automatically updated to reflect the committed changes.