Several fixes in npm, cgit and phab listers
ClosedPublic
Actions

Authored by douardda on Sep 3 2019, 12:03 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLSc67a926f266a: npm: make NpmVisitModel use the main declarative base class from core.models
rDLS342964eda77c: phabricator: fix the FullPhabricatorLister task
rDLS8785fc1a4e78: cgit: fix cgit's task module and tests

Summary

This diff consists in 3 commits:

cgit: fix cgit's task module and tests forgot some url_prefix there.

phabricator: fix the FullPhabricatorLister task

forgot the forge_url -> api_baseurl renaming in there.

npm: make NpmVisitModel use the main declarative base class from core.models

This is needed by the (refactored) db init mechanism, since this later uses the main declarative base class (thus the main MetaData instance) to gather tables to be created/dropped.

Diff Detail

Repository

rDLS Listers

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Sep 3 2019, 12:03 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 3 2019, 12:03 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tox/334/
See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tox/334/console

Harbormaster failed remote builds in B7598: Diff 6527!Sep 3 2019, 12:05 PM

ok with those fixes.

The ci is still red with errors in the swh.lister.cli.get_lister method (relative to the constructor refactoring as well).
My guess is that's not an issue since it will get deprecated by the plugin refactoring.

This revision is now accepted and ready to land.Sep 3 2019, 1:13 PM

Fix cli.py for test_cli to pass (phabricator)

Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/335/ for more details.

Harbormaster completed remote builds in B7602: Diff 6529.Sep 3 2019, 3:06 PM

ardumont accepted this revision.Sep 3 2019, 3:10 PM

Closed by commit rDLS8785fc1a4e78: cgit: fix cgit's task module and tests (authored by douardda). · Explain WhySep 3 2019, 3:11 PM

This revision was automatically updated to reflect the committed changes.

douardda mentioned this in D1504: implement listers as plugins.Sep 3 2019, 3:12 PM